Issue 2532423002: Replace unique_ptr.reset(other_unique_ptr.release() with std::move()

Issue 2532423002: Replace unique_ptr.reset(other_unique_ptr.release() with std::move() (Closed)

Created:
4 years ago by htamop

Modified:
4 years ago

Reviewers:
aelias_OOO_until_Jul13, Ben Goodger (Google)

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Replace unique_ptr.reset(other_unique_ptr.release() with std::move() BUG=644626 TAG:PLTAL! Committed: https://crrev.com/5722ddb82d35096ead26103f8663b8d68a08558b Cr-Commit-Position: refs/heads/master@{#435861}

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	AUTHORS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/renderer/history_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 20 (14 generated)

htamop

please review my firstcommit. I'll be a core comitter!!! I look forward to my code ...

4 years ago (2016-11-29 09:12:31 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532423002/40001

4 years ago (2016-12-02 04:00:19 UTC) #15

commit-bot: I haz the power

4 years ago (2016-12-02 04:56:27 UTC) #20

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/5722ddb82d35096ead26103f8663b8d68a08558b
Cr-Commit-Position: refs/heads/master@{#435861}