content/renderer/history_controller.cc - Issue 2532423002: Replace unique_ptr.reset(other_unique_ptr.release() with std::move()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/history_controller.cc

Issue 2532423002: Replace unique_ptr.reset(other_unique_ptr.release() with std::move() (Closed)

Patch Set: I edited my AUTHOR registeration in dictionary order. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/history_controller.cc

diff --git a/content/renderer/history_controller.cc b/content/renderer/history_controller.cc

index 0618765f8c8ff7bc0f7e8656f7512748e6c57efb..6369f09354e7ad7c2191745b3c781ff8f074e9cb 100644

--- a/content/renderer/history_controller.cc

+++ b/content/renderer/history_controller.cc

@@ -253,7 +253,7 @@ void HistoryController::UpdateForCommit(RenderFrameImpl* frame,

if (frame->IsMainFrame() ||

current_entry_->root().itemSequenceNumber() ==

provisional_entry_->root().itemSequenceNumber()) {

- current_entry_.reset(provisional_entry_.release());

+ current_entry_ = std::move(provisional_entry_);

}

// We're guaranteed to have a current entry now.

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »