Add libraries in corrections using SourceInfo instance of LibraryElement.

Add libraries in corrections using SourceInfo instance of LibraryElement.

We are not going to have LibraryElement(s) for the new analysis driver.

The current approach: get known library sources, compute their elements,
import these elements does not work well when there is no analysis cache.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/2368a59d6046596e154e7f27fc391a5fdc0f77fd

[Brian Wilkerson, 2016-12-01 17:52:54]

https://codereview.chromium.org/2532393008/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/util.dart (right):

https://codereview.chromium.org/2532393008/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/util.dart:1551: class SourceInfo
{
I don't understand the need for this class. Everywhere (except in the tests,
which already had a _MockSource), we are creating instances of this class from a
Source. Why not just pass around a Source?

[scheglov, 2016-12-01 18:05:21]

PTAL

https://codereview.chromium.org/2532393008/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/util.dart (right):

https://codereview.chromium.org/2532393008/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/util.dart:1551: class SourceInfo
{
On 2016/12/01 17:52:54, Brian Wilkerson wrote:
> I don't understand the need for this class. Everywhere (except in the tests,
> which already had a _MockSource), we are creating instances of this class from
a
> Source. Why not just pass around a Source?

That's fair.
I replaced SourceInfo with Source.

[Brian Wilkerson, 2016-12-01 18:20:42]

lgtm

https://codereview.chromium.org/2532393008/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/services/correction/util_test.dart (right):

https://codereview.chromium.org/2532393008/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/services/correction/util_test.dart:261: Source
_getDartSourceInfo(String uri) {
Maybe drop the "Info" here and in _getSourceInfo?

[scheglov, 2016-12-01 18:21:29]

https://codereview.chromium.org/2532393008/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/services/correction/util_test.dart (right):

https://codereview.chromium.org/2532393008/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/services/correction/util_test.dart:261: Source
_getDartSourceInfo(String uri) {
On 2016/12/01 18:20:42, Brian Wilkerson wrote:
> Maybe drop the "Info" here and in _getSourceInfo?

Done.

[scheglov, 2016-12-01 18:22:54]

Description was changed from

==========
Add libraries in corrections using SourceInfo instance of LibraryElement.

We are not going to have LibraryElement(s) for the new analysis driver.

The current approach: get known library sources, compute their elements,
import these elements does not work well when there is no analysis cache.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Add libraries in corrections using SourceInfo instance of LibraryElement.

We are not going to have LibraryElement(s) for the new analysis driver.

The current approach: get known library sources, compute their elements,
import these elements does not work well when there is no analysis cache.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/2368a59d6046596e154e7f27fc391a5fdc0f77fd
==========

[scheglov, 2016-12-01 18:22:56]

Committed patchset #2 (id:20001) manually as
2368a59d6046596e154e7f27fc391a5fdc0f77fd (presubmit successful).