Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: pkg/analysis_server/lib/src/services/correction/fix_internal.dart

Issue 2532393008: Add libraries in corrections using SourceInfo instance of LibraryElement. (Closed)
Patch Set: Replace SourceInfo with Source. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/correction/fix_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
index 716b2de1a80c2ddce9d0ae64dba2cdfc9a5ed938..3e3da6be9d60e47bc3a153d06d7009938ff90f08 100644
--- a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
+++ b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
@@ -105,7 +105,7 @@ class FixProcessor {
final LinkedHashMap<String, LinkedEditGroup> linkedPositionGroups =
new LinkedHashMap<String, LinkedEditGroup>();
Position exitPosition = null;
- Set<LibraryElement> librariesToImport = new Set<LibraryElement>();
+ Set<Source> librariesToImport = new Set<Source>();
CorrectionUtils utils;
int errorOffset;
@@ -1453,10 +1453,9 @@ class FixProcessor {
_addFix(DartFixKind.REPLACE_RETURN_TYPE_FUTURE, []);
}
- void _addFix_importLibrary(FixKind kind, LibraryElement libraryElement) {
- librariesToImport.add(libraryElement);
- Source librarySource = libraryElement.source;
- String libraryUri = getLibrarySourceUri(unitLibraryElement, librarySource);
+ void _addFix_importLibrary(FixKind kind, Source library) {
+ librariesToImport.add(library);
+ String libraryUri = getLibrarySourceUri(unitLibraryElement, library);
_addFix(kind, [libraryUri], importsOnly: true);
}
@@ -1544,7 +1543,8 @@ class FixProcessor {
continue;
}
// add import
- _addFix_importLibrary(DartFixKind.IMPORT_LIBRARY_SDK, libraryElement);
+ _addFix_importLibrary(
+ DartFixKind.IMPORT_LIBRARY_SDK, libraryElement.source);
}
}
// check project libraries
@@ -1591,7 +1591,7 @@ class FixProcessor {
fixKind = DartFixKind.IMPORT_LIBRARY_PROJECT1;
}
// Add the fix.
- _addFix_importLibrary(fixKind, libraryElement);
+ _addFix_importLibrary(fixKind, libraryElement.source);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698