pkg/analysis_server/lib/src/services/correction/assist_internal.dart - Issue 2532393008: Add libraries in corrections using SourceInfo instance of LibraryElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

Issue 2532393008: Add libraries in corrections using SourceInfo instance of LibraryElement. (Closed)

Patch Set: Replace SourceInfo with Source. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/correction/fix_internal.dart » ('j') | pkg/analysis_server/test/services/correction/util_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

diff --git a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

index 989968174a3023da781e5f66ea40df12f0074ea2..73a4beef69a9690582eeb22eeb0a5d0ea316545b 100644

--- a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

+++ b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

@@ -233,7 +233,7 @@ class AssistProcessor {

DartType type = declaredIdentifier.identifier.bestType;

if (type is InterfaceType || type is FunctionType) {

_configureTargetLocation(node);

- Set<LibraryElement> librariesToImport = new Set<LibraryElement>();

+ Set<Source> librariesToImport = new Set<Source>();

typeSource = utils.getTypeSource(type, librariesToImport);

addLibraryImports(change, unitLibraryElement, librariesToImport);

} else {

@@ -285,7 +285,7 @@ class AssistProcessor {

String typeSource;

{

_configureTargetLocation(node);

- Set<LibraryElement> librariesToImport = new Set<LibraryElement>();

+ Set<Source> librariesToImport = new Set<Source>();

typeSource = utils.getTypeSource(type, librariesToImport);

addLibraryImports(change, unitLibraryElement, librariesToImport);

}

@@ -337,7 +337,7 @@ class AssistProcessor {

String typeSource;

if (type is InterfaceType || type is FunctionType) {

_configureTargetLocation(node);

- Set<LibraryElement> librariesToImport = new Set<LibraryElement>();

+ Set<Source> librariesToImport = new Set<Source>();

typeSource = utils.getTypeSource(type, librariesToImport);

addLibraryImports(change, unitLibraryElement, librariesToImport);

} else {

@@ -1002,7 +1002,7 @@ class AssistProcessor {

String name = (node as SimpleIdentifier).name;

// prepare type

DartType type = parameterElement.type;

- Set<LibraryElement> librariesToImport = new Set<LibraryElement>();

+ Set<Source> librariesToImport = new Set<Source>();

String typeCode = utils.getTypeSource(type, librariesToImport);

// replace parameter

if (type.isDynamic) {