Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2532163002:
Comments updated as result of infinite timeout for state keys generated (Closed)
DescriptionComments updated as result of infinite timeout for state keys generated
Since the state keys are not generated as long as the time sync didn't
happen, the callback containing the state key might end up not being
invoked at all. This information has been included in the code comments.
BUG=649422
Committed: https://crrev.com/e82eb4ead074225a6fd41b139b613796554bb779
Cr-Commit-Position: refs/heads/master@{#440766}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fixed the nits #
Total comments: 2
Patch Set 3 : Improved comments #
Messages
Total messages: 21 (11 generated)
Description was changed from ========== Comments updated as result of infinite timeout for state keys generated Since the state keys are not generated as long as the time sync didn't happen, the callback containing the state key might end up not being invoked at all. This information has been included in the code comments. BUG=649422 ========== to ========== Comments updated as result of infinite timeout for state keys generated Since the state keys are not generated as long as the time sync didn't happen, the callback containing the state key might end up not being invoked at all. This information has been included in the code comments. BUG=649422 ==========
igorcov@chromium.org changed reviewers: + tnagel@chromium.org
lgtm % nit https://codereview.chromium.org/2532163002/diff/1/chromeos/dbus/session_manag... File chromeos/dbus/session_manager_client.h (right): https://codereview.chromium.org/2532163002/diff/1/chromeos/dbus/session_manag... chromeos/dbus/session_manager_client.h:214: // will be invoked with an empty state key vector in case of errors. If the Nit: "will be" --> "is"
The CQ bit was checked by igorcov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tnagel@chromium.org Link to the patchset: https://codereview.chromium.org/2532163002/#ps20001 (title: "Fixed the nits")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
igorcov@chromium.org changed reviewers: + stevenjb@chromium.org
stevenjb@ PTAL session_manager_client.h
https://codereview.chromium.org/2532163002/diff/20001/chrome/browser/chromeos... File chrome/browser/chromeos/policy/server_backed_state_keys_broker.h (right): https://codereview.chromium.org/2532163002/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/policy/server_backed_state_keys_broker.h:54: // invoked. Let's reference the issue here to give developers more context.
https://codereview.chromium.org/2532163002/diff/20001/chrome/browser/chromeos... File chrome/browser/chromeos/policy/server_backed_state_keys_broker.h (right): https://codereview.chromium.org/2532163002/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/policy/server_backed_state_keys_broker.h:54: // invoked. On 2016/12/22 19:14:05, stevenjb wrote: > Let's reference the issue here to give developers more context. Done.
lgtm
The CQ bit was checked by igorcov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tnagel@chromium.org Link to the patchset: https://codereview.chromium.org/2532163002/#ps40001 (title: "Improved comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482861105410250,
"parent_rev": "50440fd9c294e0db13496c25d0ba3adb5b7f60fb", "commit_rev":
"40c888b2ee57ad6091d9ebbf592f9308e8d7f00b"}
Message was sent while issue was closed.
Description was changed from ========== Comments updated as result of infinite timeout for state keys generated Since the state keys are not generated as long as the time sync didn't happen, the callback containing the state key might end up not being invoked at all. This information has been included in the code comments. BUG=649422 ========== to ========== Comments updated as result of infinite timeout for state keys generated Since the state keys are not generated as long as the time sync didn't happen, the callback containing the state key might end up not being invoked at all. This information has been included in the code comments. BUG=649422 Review-Url: https://codereview.chromium.org/2532163002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Comments updated as result of infinite timeout for state keys generated Since the state keys are not generated as long as the time sync didn't happen, the callback containing the state key might end up not being invoked at all. This information has been included in the code comments. BUG=649422 Review-Url: https://codereview.chromium.org/2532163002 ========== to ========== Comments updated as result of infinite timeout for state keys generated Since the state keys are not generated as long as the time sync didn't happen, the callback containing the state key might end up not being invoked at all. This information has been included in the code comments. BUG=649422 Committed: https://crrev.com/e82eb4ead074225a6fd41b139b613796554bb779 Cr-Commit-Position: refs/heads/master@{#440766} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e82eb4ead074225a6fd41b139b613796554bb779 Cr-Commit-Position: refs/heads/master@{#440766} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
