Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: chrome/browser/chromeos/policy/server_backed_state_keys_broker.h

Issue 2532163002: Comments updated as result of infinite timeout for state keys generated (Closed)
Patch Set: Improved comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/session_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/policy/server_backed_state_keys_broker.h
diff --git a/chrome/browser/chromeos/policy/server_backed_state_keys_broker.h b/chrome/browser/chromeos/policy/server_backed_state_keys_broker.h
index 6fb80e94038eab2c9fdc8ef00746af18800ea6ca..de4baf79b1af3ca7eee20f3619c647a391c555c8 100644
--- a/chrome/browser/chromeos/policy/server_backed_state_keys_broker.h
+++ b/chrome/browser/chromeos/policy/server_backed_state_keys_broker.h
@@ -46,10 +46,12 @@ class ServerBackedStateKeysBroker {
// requested yet, calling this will also trigger their initial fetch.
Subscription RegisterUpdateCallback(const base::Closure& callback);
- // Requests state keys asynchronously. Invokes the passed callback exactly
- // once (unless |this| gets destroyed before the callback happens), with the
- // current state keys passed as a parameter to the callback. If there's a
- // problem determining the state keys, the passed vector will be empty.
+ // Requests state keys asynchronously. Invokes the passed callback at most
+ // once, with the current state keys passed as a parameter to the callback. If
+ // there's a problem determining the state keys, the passed vector will be
+ // empty. If |this| gets destroyed before the callback happens or if the time
+ // sync fails / the network is not established, then the |callback| is never
+ // invoked. See http://crbug.com/649422 for more context.
void RequestStateKeys(const StateKeysCallback& callback);
// Get the set of current state keys. Empty if state keys are unavailable
« no previous file with comments | « no previous file | chromeos/dbus/session_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698