Unify HTML and SVG coordinates of LayoutSVGText

Unify HTML and SVG coordinates of LayoutSVGText

LayoutSVGText inherits from LayoutBlockFlow. During layout, at first
SVG text fragments are laid out in physical coordinates in local SVG
coordinates of LayoutSVGText, then the underlying LayoutBlockFlow and
inline boxes are laid out in the coordinate space of the bounding box
of the text fragments.

The difference between HTML and SVG coordinates of LayoutSVGText causes
some compexities, such as inconsistent coordinate space of SVG inline
box calculateBoundaries(), complicated paint offset situations for
outline and text when building paint property tree and painting (about
text fragments painted in coordinates with paint offset baked in while
outline painted with explicit paint offset), etc. Unifying the two
coordinates can avoid the complexities.

BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51
Cr-Commit-Position: refs/heads/master@{#434885}

[Xianzhu, 2016-11-26 04:42:41]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-26 04:42:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-26 05:54:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-26 05:54:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-11-27 04:59:07]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-27 04:59:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-27 06:51:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-27 06:51:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-11-27 18:08:42]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-27 18:08:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-11-27 18:13:33]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2016-11-27 18:13:34]

https://codereview.chromium.org/2531943002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h (right):

https://codereview.chromium.org/2531943002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h:51:
IncludeBlockVisualOverflowOrNot) const override;
This is to override LayoutBlock's addOutlineRects which adds outline rect using
its frameRect, by adding outline rect using objectBoundingBox(). Previously
before unifying coordinate spaces, frameRect equaled objectBoundingBox().

[commit-bot: I haz the power, 2016-11-27 19:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-27 19:56:11]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-11-28 03:33:48]

This change looks good but the test change seems unexpected. What's causing that
change in behavior?

[pdr., 2016-11-28 03:34:30]

Description was changed from

==========
Unify HTML and SVG coordinates of LayoutSVGText

LayoutSVGText inherits from LayoutBlockFlow. During layout, at first
SVG text fragments are laid out in physical coordinates in local SVG
coordinates of LayoutSVGText, then the underlying LayoutBlockFlow and
inline boxes are laid out in the coordinate space of the bounding box
of the text fragments.

The difference between HTML and SVG coordinates of LayoutSVGText causes
some compexities, such as inconsistent coordinate space of SVG inline
box calculateBoundaries(), complicated paint offset situations for
outline and text when building paint property tree and painting (about
text fragments painted in coordinates with paint offset baked in while
outline painted with explicit paint offset), etc. Unifying the two
coordinates can avoid the complexities.

BUG=666416
==========

to

==========
Unify HTML and SVG coordinates of LayoutSVGText

LayoutSVGText inherits from LayoutBlockFlow. During layout, at first
SVG text fragments are laid out in physical coordinates in local SVG
coordinates of LayoutSVGText, then the underlying LayoutBlockFlow and
inline boxes are laid out in the coordinate space of the bounding box
of the text fragments.

The difference between HTML and SVG coordinates of LayoutSVGText causes
some compexities, such as inconsistent coordinate space of SVG inline
box calculateBoundaries(), complicated paint offset situations for
outline and text when building paint property tree and painting (about
text fragments painted in coordinates with paint offset baked in while
outline painted with explicit paint offset), etc. Unifying the two
coordinates can avoid the complexities.

BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-11-28 17:54:11]

On 2016/11/28 03:33:48, pdr. wrote:
> This change looks good but the test change seems unexpected. What's causing
that
> change in behavior?

The new thing looking like a ' is part of the caret when the svg element is in
design mode. I found that this is the correct result. Before this CL the caret
location was incorrect and out of the visible area. I should have explained this
at the first place.

[Xianzhu, 2016-11-28 18:56:21]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 18:57:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-11-28 19:09:31]

On 2016/11/28 at 17:54:11, wangxianzhu wrote:
> On 2016/11/28 03:33:48, pdr. wrote:
> > This change looks good but the test change seems unexpected. What's causing
that
> > change in behavior?
> 
> The new thing looking like a ' is part of the caret when the svg element is in
design mode. I found that this is the correct result. Before this CL the caret
location was incorrect and out of the visible area. I should have explained this
at the first place.

OK cool, LGTM

[commit-bot: I haz the power, 2016-11-28 19:40:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 19:40:43]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Xianzhu, 2016-11-28 20:15:39]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 20:17:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 20:30:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:30:36]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Xianzhu, 2016-11-29 00:29:32]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-11-29 00:29:32]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2531943002/#ps100001
(title: "-")

[commit-bot: I haz the power, 2016-11-29 00:30:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 00:36:54]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Xianzhu, 2016-11-29 00:45:57]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-11-29 00:47:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 04:12:12]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480380357528340,
"parent_rev": "5b2d8b8e15c8a21d24bfb88c4287e131147166fc", "commit_rev":
"a08d5d3fa42f56454709c03695dd05f56c99480b"}

[commit-bot: I haz the power, 2016-11-29 04:13:36]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-29 04:18:01]

Description was changed from

==========
Unify HTML and SVG coordinates of LayoutSVGText

LayoutSVGText inherits from LayoutBlockFlow. During layout, at first
SVG text fragments are laid out in physical coordinates in local SVG
coordinates of LayoutSVGText, then the underlying LayoutBlockFlow and
inline boxes are laid out in the coordinate space of the bounding box
of the text fragments.

The difference between HTML and SVG coordinates of LayoutSVGText causes
some compexities, such as inconsistent coordinate space of SVG inline
box calculateBoundaries(), complicated paint offset situations for
outline and text when building paint property tree and painting (about
text fragments painted in coordinates with paint offset baked in while
outline painted with explicit paint offset), etc. Unifying the two
coordinates can avoid the complexities.

BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Unify HTML and SVG coordinates of LayoutSVGText

LayoutSVGText inherits from LayoutBlockFlow. During layout, at first
SVG text fragments are laid out in physical coordinates in local SVG
coordinates of LayoutSVGText, then the underlying LayoutBlockFlow and
inline boxes are laid out in the coordinate space of the bounding box
of the text fragments.

The difference between HTML and SVG coordinates of LayoutSVGText causes
some compexities, such as inconsistent coordinate space of SVG inline
box calculateBoundaries(), complicated paint offset situations for
outline and text when building paint property tree and painting (about
text fragments painted in coordinates with paint offset baked in while
outline painted with explicit paint offset), etc. Unifying the two
coordinates can avoid the complexities.

BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51
Cr-Commit-Position: refs/heads/master@{#434885}
==========

[commit-bot: I haz the power, 2016-11-29 04:18:02]

Patchset 6 (id:??) landed as
https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51
Cr-Commit-Position: refs/heads/master@{#434885}