Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2533633002: Don't flip SVG text coordinates (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
pdr.
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, rwlbuis, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, fs, krit, f(malita), jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, dshwang, pdr+svgwatchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't flip SVG text coordinates This is a partial revert of https://codereview.chromium.org/2524113002/ which is incomplete about SVG text coordinate flipping. We could make it complete, but before we think everything clear, I'd like to revert the part first. At least all existing and new text cases about vertical SVG text pass with this CL. (Putting aside that we reuse InlineBox/LayoutBlockFlow code for SVG text, flipped writing-mode doesn't apply to SVG text because it doesn't have multi-line block direction layout. Vertical-rl and vertical-lr are actually equivalent for SVG text.) BUG=666416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 R=pdr@chromium.org Committed: https://crrev.com/9e370a37157d26aa866cab25ff0649f162967638 Cr-Commit-Position: refs/heads/master@{#434797}

Patch Set 1 #

Patch Set 2 : Rebaseline-cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/platform/linux/svg/text/tspan-multiple-outline-vertical-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/svg/text/tspan-multiple-outline-vertical-expected.txt View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/svg/text/tspan-multiple-outline-vertical-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/svg/text/tspan-multiple-outline-vertical-expected.txt View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/svg/text/tspan-multiple-outline-vertical-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/svg/text/tspan-multiple-outline-vertical-expected.txt View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/text/tspan-multiple-outline-vertical.svg View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (16 generated)
Xianzhu
4 years ago (2016-11-27 18:01:28 UTC) #9
pdr.
On 2016/11/27 at 18:01:28, wangxianzhu wrote: > LGTM
4 years ago (2016-11-28 03:35:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533633002/20001
4 years ago (2016-11-28 17:57:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-28 20:43:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533633002/20001
4 years ago (2016-11-28 21:41:06 UTC) #19
Xianzhu
Committed patchset #2 (id:20001) to pending queue manually as eab4fb729f5e3e59ce4777e5979edf0e9b9b32bd (presubmit successful).
4 years ago (2016-11-29 00:28:26 UTC) #21
commit-bot: I haz the power
4 years ago (2016-11-29 00:35:17 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e370a37157d26aa866cab25ff0649f162967638
Cr-Commit-Position: refs/heads/master@{#434797}

Powered by Google App Engine
This is Rietveld 408576698