Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2531333004: Revert of win: Remove unneeded references to visual_studio_version now that it's always 2015. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
Reviewers:
Nico, scottmg, brucedawson
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of win: Remove unneeded references to visual_studio_version now that it's always 2015. (patchset #4 id:60001 of https://codereview.chromium.org/2450933002/ ) Reason for revert: V8 relies on this. Original issue's description: > win: Remove unneeded references to visual_studio_version now that it's always 2015. > > BUG= > > Committed: https://crrev.com/a628db5056deb88589224bd68dcd9ec029932c83 > Cr-Commit-Position: refs/heads/master@{#427463} TBR=scottmg@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/f89b499961b139f38e8e01282a82d4ba5d21506e Cr-Commit-Position: refs/heads/master@{#434945}

Patch Set 1 #

Patch Set 2 : Comment + rebase #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -76 lines) Patch
M base/BUILD.gn View 1 2 chunks +60 lines, -48 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 4 chunks +19 lines, -13 lines 2 comments Download
M build/config/win/BUILD.gn View 1 1 chunk +26 lines, -14 lines 0 comments Download
M build/config/win/visual_studio_version.gni View 1 1 chunk +1 line, -1 line 2 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Michael Achenbach
Created Revert of win: Remove unneeded references to visual_studio_version now that it's always 2015.
4 years ago (2016-11-29 09:02:53 UTC) #1
Michael Achenbach
TBR https://codereview.chromium.org/2531333004/diff/150001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2531333004/diff/150001/build/config/compiler/BUILD.gn#newcode920 build/config/compiler/BUILD.gn:920: ] Needed to merge non-trivially here... https://codereview.chromium.org/2531333004/diff/150001/build/config/compiler/BUILD.gn#newcode1595 build/config/compiler/BUILD.gn:1595: ...
4 years ago (2016-11-29 09:21:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531333004/150001
4 years ago (2016-11-29 09:21:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:150001)
4 years ago (2016-11-29 10:21:53 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f89b499961b139f38e8e01282a82d4ba5d21506e Cr-Commit-Position: refs/heads/master@{#434945}
4 years ago (2016-11-29 10:26:17 UTC) #9
Nico
lgtm, thanks reintroducing the "keep in sync with common.gypi" comments is a bit unfortunate, but ...
4 years ago (2016-11-29 16:23:45 UTC) #10
Michael Achenbach
https://codereview.chromium.org/2531333004/diff/150001/build/config/win/visual_studio_version.gni File build/config/win/visual_studio_version.gni (right): https://codereview.chromium.org/2531333004/diff/150001/build/config/win/visual_studio_version.gni#newcode12 build/config/win/visual_studio_version.gni:12: # Use "2013" for Visual Studio 2013, or "2013e" ...
4 years ago (2016-11-30 08:18:59 UTC) #11
Michael Achenbach
4 years ago (2016-12-02 14:55:56 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:150001) has been created in
https://codereview.chromium.org/2540013006/ by machenbach@chromium.org.

The reason for reverting is: V8 is on 2015 now..

Powered by Google App Engine
This is Rietveld 408576698