Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: base/BUILD.gn

Issue 2531333004: Revert of win: Remove unneeded references to visual_studio_version now that it's always 2015. (Closed)
Patch Set: Comment + rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | build/config/compiler/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 24 matching lines...) Expand all
35 # Override this value to give a specific build date. 35 # Override this value to give a specific build date.
36 # See //base/build_time.cc and //build/write_build_date_header.py for more 36 # See //base/build_time.cc and //build/write_build_date_header.py for more
37 # details and the expected format. 37 # details and the expected format.
38 override_build_date = "N/A" 38 override_build_date = "N/A"
39 } 39 }
40 40
41 if (is_android) { 41 if (is_android) {
42 import("//build/config/android/rules.gni") 42 import("//build/config/android/rules.gni")
43 } 43 }
44 44
45 if (is_win) {
46 import("//build/config/win/visual_studio_version.gni")
47 }
48
45 config("base_flags") { 49 config("base_flags") {
46 if (is_clang) { 50 if (is_clang) {
47 cflags = [ 51 cflags = [
48 # Don't die on dtoa code that uses a char as an array index. 52 # Don't die on dtoa code that uses a char as an array index.
49 # This is required solely for base/third_party/dmg_fp/dtoa_wrapper.cc. 53 # This is required solely for base/third_party/dmg_fp/dtoa_wrapper.cc.
50 "-Wno-char-subscripts", 54 "-Wno-char-subscripts",
51 ] 55 ]
52 } 56 }
53 } 57 }
54 58
(...skipping 1195 matching lines...) Expand 10 before | Expand all | Expand 10 after
1250 # preinstalled on the target machine. The debug runtimes have a "d" at 1254 # preinstalled on the target machine. The debug runtimes have a "d" at
1251 # the end. 1255 # the end.
1252 if (is_debug) { 1256 if (is_debug) {
1253 vcrt_suffix = "d" 1257 vcrt_suffix = "d"
1254 } else { 1258 } else {
1255 vcrt_suffix = "" 1259 vcrt_suffix = ""
1256 } 1260 }
1257 1261
1258 # These runtime files are copied to the output directory by the 1262 # These runtime files are copied to the output directory by the
1259 # vs_toolchain script that runs as part of toolchain configuration. 1263 # vs_toolchain script that runs as part of toolchain configuration.
1260 data += [ 1264 if (visual_studio_version == "2015") {
1261 "$root_out_dir/msvcp140${vcrt_suffix}.dll", 1265 data += [
1262 "$root_out_dir/vccorlib140${vcrt_suffix}.dll", 1266 "$root_out_dir/msvcp140${vcrt_suffix}.dll",
1263 "$root_out_dir/vcruntime140${vcrt_suffix}.dll", 1267 "$root_out_dir/vccorlib140${vcrt_suffix}.dll",
1268 "$root_out_dir/vcruntime140${vcrt_suffix}.dll",
1264 1269
1265 # Universal Windows 10 CRT files 1270 # Universal Windows 10 CRT files
1266 "$root_out_dir/api-ms-win-core-console-l1-1-0.dll", 1271 "$root_out_dir/api-ms-win-core-console-l1-1-0.dll",
1267 "$root_out_dir/api-ms-win-core-datetime-l1-1-0.dll", 1272 "$root_out_dir/api-ms-win-core-datetime-l1-1-0.dll",
1268 "$root_out_dir/api-ms-win-core-debug-l1-1-0.dll", 1273 "$root_out_dir/api-ms-win-core-debug-l1-1-0.dll",
1269 "$root_out_dir/api-ms-win-core-errorhandling-l1-1-0.dll", 1274 "$root_out_dir/api-ms-win-core-errorhandling-l1-1-0.dll",
1270 "$root_out_dir/api-ms-win-core-file-l1-1-0.dll", 1275 "$root_out_dir/api-ms-win-core-file-l1-1-0.dll",
1271 "$root_out_dir/api-ms-win-core-file-l1-2-0.dll", 1276 "$root_out_dir/api-ms-win-core-file-l1-2-0.dll",
1272 "$root_out_dir/api-ms-win-core-file-l2-1-0.dll", 1277 "$root_out_dir/api-ms-win-core-file-l2-1-0.dll",
1273 "$root_out_dir/api-ms-win-core-handle-l1-1-0.dll", 1278 "$root_out_dir/api-ms-win-core-handle-l1-1-0.dll",
1274 "$root_out_dir/api-ms-win-core-heap-l1-1-0.dll", 1279 "$root_out_dir/api-ms-win-core-heap-l1-1-0.dll",
1275 "$root_out_dir/api-ms-win-core-interlocked-l1-1-0.dll", 1280 "$root_out_dir/api-ms-win-core-interlocked-l1-1-0.dll",
1276 "$root_out_dir/api-ms-win-core-libraryloader-l1-1-0.dll", 1281 "$root_out_dir/api-ms-win-core-libraryloader-l1-1-0.dll",
1277 "$root_out_dir/api-ms-win-core-localization-l1-2-0.dll", 1282 "$root_out_dir/api-ms-win-core-localization-l1-2-0.dll",
1278 "$root_out_dir/api-ms-win-core-memory-l1-1-0.dll", 1283 "$root_out_dir/api-ms-win-core-memory-l1-1-0.dll",
1279 "$root_out_dir/api-ms-win-core-namedpipe-l1-1-0.dll", 1284 "$root_out_dir/api-ms-win-core-namedpipe-l1-1-0.dll",
1280 "$root_out_dir/api-ms-win-core-processenvironment-l1-1-0.dll", 1285 "$root_out_dir/api-ms-win-core-processenvironment-l1-1-0.dll",
1281 "$root_out_dir/api-ms-win-core-processthreads-l1-1-0.dll", 1286 "$root_out_dir/api-ms-win-core-processthreads-l1-1-0.dll",
1282 "$root_out_dir/api-ms-win-core-processthreads-l1-1-1.dll", 1287 "$root_out_dir/api-ms-win-core-processthreads-l1-1-1.dll",
1283 "$root_out_dir/api-ms-win-core-profile-l1-1-0.dll", 1288 "$root_out_dir/api-ms-win-core-profile-l1-1-0.dll",
1284 "$root_out_dir/api-ms-win-core-rtlsupport-l1-1-0.dll", 1289 "$root_out_dir/api-ms-win-core-rtlsupport-l1-1-0.dll",
1285 "$root_out_dir/api-ms-win-core-string-l1-1-0.dll", 1290 "$root_out_dir/api-ms-win-core-string-l1-1-0.dll",
1286 "$root_out_dir/api-ms-win-core-synch-l1-1-0.dll", 1291 "$root_out_dir/api-ms-win-core-synch-l1-1-0.dll",
1287 "$root_out_dir/api-ms-win-core-synch-l1-2-0.dll", 1292 "$root_out_dir/api-ms-win-core-synch-l1-2-0.dll",
1288 "$root_out_dir/api-ms-win-core-sysinfo-l1-1-0.dll", 1293 "$root_out_dir/api-ms-win-core-sysinfo-l1-1-0.dll",
1289 "$root_out_dir/api-ms-win-core-timezone-l1-1-0.dll", 1294 "$root_out_dir/api-ms-win-core-timezone-l1-1-0.dll",
1290 "$root_out_dir/api-ms-win-core-util-l1-1-0.dll", 1295 "$root_out_dir/api-ms-win-core-util-l1-1-0.dll",
1291 "$root_out_dir/api-ms-win-crt-conio-l1-1-0.dll", 1296 "$root_out_dir/api-ms-win-crt-conio-l1-1-0.dll",
1292 "$root_out_dir/api-ms-win-crt-convert-l1-1-0.dll", 1297 "$root_out_dir/api-ms-win-crt-convert-l1-1-0.dll",
1293 "$root_out_dir/api-ms-win-crt-environment-l1-1-0.dll", 1298 "$root_out_dir/api-ms-win-crt-environment-l1-1-0.dll",
1294 "$root_out_dir/api-ms-win-crt-filesystem-l1-1-0.dll", 1299 "$root_out_dir/api-ms-win-crt-filesystem-l1-1-0.dll",
1295 "$root_out_dir/api-ms-win-crt-heap-l1-1-0.dll", 1300 "$root_out_dir/api-ms-win-crt-heap-l1-1-0.dll",
1296 "$root_out_dir/api-ms-win-crt-locale-l1-1-0.dll", 1301 "$root_out_dir/api-ms-win-crt-locale-l1-1-0.dll",
1297 "$root_out_dir/api-ms-win-crt-math-l1-1-0.dll", 1302 "$root_out_dir/api-ms-win-crt-math-l1-1-0.dll",
1298 "$root_out_dir/api-ms-win-crt-multibyte-l1-1-0.dll", 1303 "$root_out_dir/api-ms-win-crt-multibyte-l1-1-0.dll",
1299 "$root_out_dir/api-ms-win-crt-private-l1-1-0.dll", 1304 "$root_out_dir/api-ms-win-crt-private-l1-1-0.dll",
1300 "$root_out_dir/api-ms-win-crt-process-l1-1-0.dll", 1305 "$root_out_dir/api-ms-win-crt-process-l1-1-0.dll",
1301 "$root_out_dir/api-ms-win-crt-runtime-l1-1-0.dll", 1306 "$root_out_dir/api-ms-win-crt-runtime-l1-1-0.dll",
1302 "$root_out_dir/api-ms-win-crt-stdio-l1-1-0.dll", 1307 "$root_out_dir/api-ms-win-crt-stdio-l1-1-0.dll",
1303 "$root_out_dir/api-ms-win-crt-string-l1-1-0.dll", 1308 "$root_out_dir/api-ms-win-crt-string-l1-1-0.dll",
1304 "$root_out_dir/api-ms-win-crt-time-l1-1-0.dll", 1309 "$root_out_dir/api-ms-win-crt-time-l1-1-0.dll",
1305 "$root_out_dir/api-ms-win-crt-utility-l1-1-0.dll", 1310 "$root_out_dir/api-ms-win-crt-utility-l1-1-0.dll",
1306 "$root_out_dir/ucrtbase${vcrt_suffix}.dll", 1311 "$root_out_dir/ucrtbase${vcrt_suffix}.dll",
1307 ] 1312 ]
1313 } else {
1314 # TODO(thakis): V8 still relies on 2013: http://crbug.com/603131.
1315 data += [
1316 "$root_out_dir/msvcp120${vcrt_suffix}.dll",
1317 "$root_out_dir/msvcr120${vcrt_suffix}.dll",
1318 ]
1319 }
1308 if (is_asan) { 1320 if (is_asan) {
1309 if (current_cpu == "x64") { 1321 if (current_cpu == "x64") {
1310 data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang _rt.asan_dynamic-x86_64.dll" ] 1322 data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang _rt.asan_dynamic-x86_64.dll" ]
1311 } else { 1323 } else {
1312 data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang _rt.asan_dynamic-i386.dll" ] 1324 data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang _rt.asan_dynamic-i386.dll" ]
1313 } 1325 }
1314 } 1326 }
1315 } 1327 }
1316 1328
1317 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 1329 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
(...skipping 1195 matching lines...) Expand 10 before | Expand all | Expand 10 after
2513 } 2525 }
2514 2526
2515 fuzzer_test("base_json_correctness_fuzzer") { 2527 fuzzer_test("base_json_correctness_fuzzer") {
2516 sources = [ 2528 sources = [
2517 "json/correctness_fuzzer.cc", 2529 "json/correctness_fuzzer.cc",
2518 ] 2530 ]
2519 deps = [ 2531 deps = [
2520 ":base", 2532 ":base",
2521 ] 2533 ]
2522 } 2534 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | build/config/compiler/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698