build/config/win/visual_studio_version.gni - Issue 2531333004: Revert of win: Remove unneeded references to visual_studio_version now that it's always 2015.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/win/visual_studio_version.gni

Issue 2531333004: Revert of win: Remove unneeded references to visual_studio_version now that it's always 2015. (Closed)

Patch Set: Comment + rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/win/visual_studio_version.gni

diff --git a/build/config/win/visual_studio_version.gni b/build/config/win/visual_studio_version.gni

index 982fbe8d3f0d0294e28e206638cfa3ee3a902745..5bfa9a76202fdb67cd32db2bcb36ec2be60bcc81 100644

--- a/build/config/win/visual_studio_version.gni

+++ b/build/config/win/visual_studio_version.gni

@@ -9,7 +9,7 @@ declare_args() {

visual_studio_path = ""

# Version of Visual Studio pointed to by the visual_studio_path.

- # Currently always "2015".

+ # Use "2013" for Visual Studio 2013, or "2013e" for the Express version.

Nico 2016/11/29 16:23:45 this is where i would've put the comment

Michael Achenbach 2016/11/30 08:18:59 Ah - yes - that would have been better indeed. Let

visual_studio_version = ""

# Directory of the Windows driver kit. If visual_studio_path is empty, this