Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: third_party/WebKit/Source/devtools/front_end/common/Object.js

Issue 2530893003: [DevTools] Remove support for string event types. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/common/Object.js
diff --git a/third_party/WebKit/Source/devtools/front_end/common/Object.js b/third_party/WebKit/Source/devtools/front_end/common/Object.js
index 6a389f7d9fc64b8b9f75b83794d29cc0f448ec25..8a308d907cd8188887c5a98b04364598dec39bf0 100644
--- a/third_party/WebKit/Source/devtools/front_end/common/Object.js
+++ b/third_party/WebKit/Source/devtools/front_end/common/Object.js
@@ -29,7 +29,7 @@
Common.Object = class {
/**
* @override
- * @param {string|symbol} eventType
+ * @param {symbol} eventType
* @param {function(!Common.Event)} listener
* @param {!Object=} thisObject
* @return {!Common.EventTarget.EventDescriptor}
@@ -48,7 +48,7 @@ Common.Object = class {
/**
* @override
- * @param {string|symbol} eventType
+ * @param {symbol} eventType
* @param {function(!Common.Event)} listener
* @param {!Object=} thisObject
*/
@@ -76,7 +76,7 @@ Common.Object = class {
/**
* @override
- * @param {string|symbol} eventType
+ * @param {symbol} eventType
* @return {boolean}
*/
hasEventListeners(eventType) {
@@ -85,7 +85,7 @@ Common.Object = class {
/**
* @override
- * @param {string|symbol} eventType
+ * @param {symbol} eventType
* @param {*=} eventData
* @return {boolean}
*/
@@ -111,7 +111,7 @@ Common.Object = class {
Common.Event = class {
/**
* @param {!Common.EventTarget} target
- * @param {string|symbol} type
+ * @param {symbol} type
* @param {*=} data
*/
constructor(target, type, data) {
@@ -159,7 +159,7 @@ Common.EventTarget.removeEventListeners = function(eventList) {
Common.EventTarget.prototype = {
/**
- * @param {string|symbol} eventType
+ * @param {symbol} eventType
* @param {function(!Common.Event)} listener
* @param {!Object=} thisObject
* @return {!Common.EventTarget.EventDescriptor}
@@ -167,7 +167,7 @@ Common.EventTarget.prototype = {
addEventListener(eventType, listener, thisObject) {},
/**
- * @param {string|symbol} eventType
+ * @param {symbol} eventType
* @param {function(!Common.Event)} listener
* @param {!Object=} thisObject
*/
@@ -176,13 +176,13 @@ Common.EventTarget.prototype = {
removeAllListeners() {},
/**
- * @param {string|symbol} eventType
+ * @param {symbol} eventType
* @return {boolean}
*/
hasEventListeners(eventType) {},
/**
- * @param {string|symbol} eventType
+ * @param {symbol} eventType
* @param {*=} eventData
* @return {boolean}
*/
@@ -195,7 +195,7 @@ Common.EventTarget.prototype = {
Common.EventTarget.EventDescriptor = class {
/**
* @param {!Common.EventTarget} eventTarget
- * @param {string|symbol} eventType
+ * @param {symbol} eventType
* @param {(!Object|undefined)} receiver
* @param {function(?):?} method
*/
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698