chrome/common/extensions/features/complex_feature.cc - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/complex_feature.cc

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/browser_action.json ('K') | « chrome/common/extensions/api/browser_action.json ('k') | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('j') | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/complex_feature.cc

diff --git a/chrome/common/extensions/features/complex_feature.cc b/chrome/common/extensions/features/complex_feature.cc

index 57c9ad4d943bf730a22874276e5f9fd9e3580cc1..f2ee29828ad925c31422ee3ced56b1ea36cbc4a3 100644

--- a/chrome/common/extensions/features/complex_feature.cc

+++ b/chrome/common/extensions/features/complex_feature.cc

@@ -66,7 +66,7 @@ std::set<Feature::Context>* ComplexFeature::GetContexts() {

}

bool ComplexFeature::IsInternal() const {

- NOTREACHED();

+ // TODO(justinlin): Handle this correctly.

Finnur 2013/10/15 10:44:21 Um.... ? What is this about?

justinlin 2013/10/16 07:06:48 Clarified.. somewhat. It's mostly because we are e

return false;

}