Implement initial chrome.browserAction.openPopup API.

chrome/common/extensions/features/complex_feature.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/features/complex_feature.h"
 
 namespace extensions {
 
 ComplexFeature::ComplexFeature(scoped_ptr<FeatureList> features) {
   DCHECK_GT(features->size(), 0UL);
@@ skipping 48 matching lines @@
 
 std::set<Feature::Context>* ComplexFeature::GetContexts() {
   // TODO(justinlin): Current use cases for ComplexFeatures are simple (e.g.
   // allow API in dev channel for everyone but stable channel for a whitelist),
   // but if they get more complicated, we need to return some meaningful context
   // set. Either that or remove this method from the Feature interface.
   return features_[0]->GetContexts();
 }
 
 bool ComplexFeature::IsInternal() const {
-  NOTREACHED();
+  // TODO(justinlin): Handle this correctly.

[Finnur, 2013/10/15 10:44:21]

Um.... ? What is this about?

[justinlin, 2013/10/16 07:06:48]

Clarified.. somewhat. It's mostly because we are enabling for both dev and a
whitelist, so it goes through ComplexFeature. There currently isn't much of a
way to return some complex IsInternal value, so just return the first item's
IsInternal result.

   return false;
 }
 
 std::string ComplexFeature::GetAvailabilityMessage(AvailabilityResult result,
                                                    Manifest::Type type,
                                                    const GURL& url) const {
   if (result == IS_AVAILABLE)
     return std::string();
 
   // TODO(justinlin): Form some kind of combined availabilities/messages from
   // SimpleFeatures.
   return features_[0]->GetAvailabilityMessage(result, type, url);
 }
 
 bool ComplexFeature::IsIdInWhitelist(const std::string& extension_id) const {
   for (FeatureList::const_iterator it = features_.begin();
        it != features_.end(); ++it) {
     if ((*it)->IsIdInWhitelist(extension_id))
       return true;
   }
   return false;
 }
 
 }  // namespace extensions