Chromium Code Reviews| Index: chrome/common/extensions/api/browser_action.json |
| diff --git a/chrome/common/extensions/api/browser_action.json b/chrome/common/extensions/api/browser_action.json |
| index 85dd9bb2db3a3f0f9866e46a819b2e4fe250712a..f626d4f7a0eb2dd57c7dddd539cef069a5b253d4 100644 |
| --- a/chrome/common/extensions/api/browser_action.json |
| +++ b/chrome/common/extensions/api/browser_action.json |
| @@ -310,6 +310,25 @@ |
| "description": "The id of the tab for which you want to modify the browser action." |
| } |
| ] |
| + }, |
| + { |
| + "name": "openPopup", |
| + "type": "function", |
| + "description": "Opens the extension popup window without a user action. The popup will be from the usual location if the button is not hidden and anchored from the settings button otherwise.", |
|
Finnur
2013/10/15 10:44:21
nit: Is that "anchored" or "anchor ed"?
More impo
justinlin
2013/10/16 07:06:48
Ha, it is "anchored" in the code. Not sure why cod
Finnur
2013/10/16 15:01:26
I asked not to prompt you to do it in this changel
justinlin
2013/10/16 19:31:29
Yes, I can tackle them or maybe someone on my team
|
| + "nodoc": true, |
| + "parameters": [ |
| + { |
| + "type": "function", |
| + "name": "callback", |
| + "parameters": [ |
| + { |
| + "name": "popupView", |
| + "type": "object", |
| + "additionalProperties": { "type": "any" } |
| + } |
| + ] |
|
Finnur
2013/10/15 10:44:21
Is it necessary to return the view here? Is this a
Matt Perry
2013/10/15 21:29:41
Should be fine. Extensions can already get the pop
Finnur
2013/10/16 15:01:26
Yeah. Minor short-circuit in my brain. For a minut
|
| + } |
| + ] |
| } |
| ], |
| "events": [ |