Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Issue 2530353002: Views: Add a11y information for IconLabelBubbleView and LocationIconView. (Closed)
Patch Set: Review comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
index 9d1812a681cfa1098835587e146c376161d064fd..627e88862f1bb379ca1c26e4d67ca6ded4f85199 100644
--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
@@ -73,6 +73,9 @@ class IconLabelBubbleView : public views::InkDropHostView {
bool OnKeyPressed(const ui::KeyEvent& event) override;
bool OnKeyReleased(const ui::KeyEvent& event) override;
void OnNativeThemeChanged(const ui::NativeTheme* native_theme) override;
+ void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
Peter Kasting 2016/12/06 04:20:28 Nit: This goes above OnNativeThemeChanged (match s
Patti Lor 2016/12/06 07:07:21 Thanks for picking that up, fixed!
+
+ // views::InkDropHostView:
Peter Kasting 2016/12/06 04:20:28 Nit: Don't add this separate divider, instead rewo
Patti Lor 2016/12/06 07:07:21 Done.
void AddInkDropLayer(ui::Layer* ink_drop_layer) override;
void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;
std::unique_ptr<views::InkDropHighlight> CreateInkDropHighlight()

Powered by Google App Engine
This is Rietveld 408576698