Views: Add a11y information for IconLabelBubbleView and LocationIconView.

chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ICON_LABEL_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ICON_LABEL_BUBBLE_VIEW_H_
 
 #include <string>
 
 #include "base/macros.h"
@@ skipping 55 matching lines @@
   // The view has been activated by a user gesture such as spacebar. Returns
   // true if some handling was performed.
   virtual bool OnActivate(const ui::Event& event);
 
   // views::View:
   gfx::Size GetPreferredSize() const override;
   void Layout() override;
   bool OnKeyPressed(const ui::KeyEvent& event) override;
   bool OnKeyReleased(const ui::KeyEvent& event) override;
   void OnNativeThemeChanged(const ui::NativeTheme* native_theme) override;
+  void GetAccessibleNodeData(ui::AXNodeData* node_data) override;

[Peter Kasting, 2016/12/06 04:20:28]

Nit: This goes above OnNativeThemeChanged (match superclass declaration order).

[Patti Lor, 2016/12/06 07:07:21]

Thanks for picking that up, fixed!

+
+  // views::InkDropHostView:

[Peter Kasting, 2016/12/06 04:20:28]

Nit: Don't add this separate divider, instead reword the "views::View" comment
above to "views::InkDropHostView", since that's the only direct base class of
this class (it doesn't directly subclass View).

[Patti Lor, 2016/12/06 07:07:21]

Done.

   void AddInkDropLayer(ui::Layer* ink_drop_layer) override;
   void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;
   std::unique_ptr<views::InkDropHighlight> CreateInkDropHighlight()
       const override;
   SkColor GetInkDropBaseColor() const override;
 
   const gfx::FontList& font_list() const { return label_->font_list(); }
 
   SkColor GetParentBackgroundColor() const;
 
@@ skipping 18 matching lines @@
   void OnPaint(gfx::Canvas* canvas) override;
 
   // The contents of the bubble.
   views::ImageView* image_;
   views::Label* label_;
 
   DISALLOW_COPY_AND_ASSIGN(IconLabelBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ICON_LABEL_BUBBLE_VIEW_H_