Views: Add a11y information for IconLabelBubbleView and LocationIconView.

chrome/browser/ui/views/location_bar/location_icon_view.h

Index: chrome/browser/ui/views/location_bar/location_icon_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_icon_view.h b/chrome/browser/ui/views/location_bar/location_icon_view.h
index 9bc850f1ff464e0392b3ce867d1dd57e8066f289..a16501dfaaf0ed16014b40692228bb96efa5d3fc 100644
--- a/chrome/browser/ui/views/location_bar/location_icon_view.h
+++ b/chrome/browser/ui/views/location_bar/location_icon_view.h
@@ -36,6 +36,7 @@ class LocationIconView : public IconLabelBubbleView,
                       base::string16* tooltip) const override;
   SkColor GetTextColor() const override;
   bool OnActivate(const ui::Event& event) override;
+  void GetAccessibleNodeData(ui::AXNodeData* node_data) override;

[Peter Kasting, 2016/12/06 04:20:28]

Nit: Goes above GetTextColor() (matches superclasses' declaration order)

[Patti Lor, 2016/12/06 07:07:21]

I'm a bit confused here, isn't GetAccessibleNodeData() declared after
IconLabelBubbleView::GetTextColor() and IconLabelBubbleView::OnActivate()? I've
left as is for now, but please clarify if I'm misunderstanding.

[Peter Kasting, 2016/12/06 07:22:34]

This is a tricky case, since IconLabelBubbleView overrides that method after
declaring the others, and the actual override itself comes from a base class.

Since there are no formal rules governing this order (the "keep in superclass
order" is an informal, best-effort rule in some parts of Views), the real answer
is "do whatever you want".

My informal answer would be that GetAccessibleNodeData() was originally declared
in View rather than IconLabelBubbleView, it will appear first in the overall
vtable, and thus should go first.  This will tend to order things in groups:
"Methods originally declared in View, Methods originally declared in
IconLabelBubbleView, etc." But Views code itself is not consistent about this,
so don't worry too much.

[Patti Lor, 2016/12/07 01:56:58]

Ok, thanks for your explanation!

 
   // Whether we should show the tooltip for this icon or not.
   void set_show_tooltip(bool show_tooltip) { show_tooltip_ = show_tooltip; }