Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2530223002:
Stop accepting a null reply in base::PostTaskAndReplyWithResult(). (Closed)
DescriptionStop accepting a null reply in base::PostTaskAndReplyWithResult().
BUG=162712
Committed: https://crrev.com/3be0e4b7fc2f49799bebce2637f85514d4eead80
Cr-Commit-Position: refs/heads/master@{#435227}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #
Total comments: 1
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 29 (20 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
fdoray@chromium.org changed reviewers: + dcheng@chromium.org
PTAL
LGTM! https://codereview.chromium.org/2530223002/diff/40001/base/task_runner_util.h File base/task_runner_util.h (right): https://codereview.chromium.org/2530223002/diff/40001/base/task_runner_util.h... base/task_runner_util.h:55: DCHECK(reply); TIL that Callback can convert to bool.
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480507196083650,
"parent_rev": "11d96cf69d9f3ea7ff675bd2a8e66a66bf53e470", "commit_rev":
"86bf03fa45a285853481af40dc8ce7afc4d3e65c"}
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Stop accepting a null reply in base::PostTaskAndReplyWithResult(). BUG=162712 ========== to ========== Stop accepting a null reply in base::PostTaskAndReplyWithResult(). BUG=162712 Committed: https://crrev.com/3be0e4b7fc2f49799bebce2637f85514d4eead80 Cr-Commit-Position: refs/heads/master@{#435227} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/3be0e4b7fc2f49799bebce2637f85514d4eead80 Cr-Commit-Position: refs/heads/master@{#435227} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
