|
|
DescriptionMove PostTaskAndReplyWithResult() adapters to a separate header.
This will allow base::PostTaskAndReplyWithResult() adapters to be
re-used from base/task_scheduler/post_task.h without indirectly
including the declaration of base::PostTaskAndReplyWithResult() in
every file that includes base/task_scheduler/post_task.h.
Note: task_runner_util.h will be renamed to
post_task_and_reply_with_result.h in a separate CL.
BUG=
TBR=sky@chromium.org,pkasting@chromium.org
Committed: https://crrev.com/e94a9457a1bf46afa59c5678d1d2208e5eec7278
Cr-Commit-Position: refs/heads/master@{#435296}
Patch Set 1 #Patch Set 2 : add missing include #Patch Set 3 : add missing header in history_service.cc #Patch Set 4 : add missing header #
Messages
Total messages: 38 (21 generated)
fdoray@chromium.org changed reviewers: + dcheng@chromium.org
PTAL
Description was changed from ========== Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. BUG= ========== to ========== Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. Note: task_runner_util.h will be renamed to post_task_and_reply_with_result.h in a separate CL. BUG= ==========
LGTM Feels a bit weird IMO, but I don't see a good reason not to do this either.
The CQ bit was checked by fdoray@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2530223002 Patch 40001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2535843002/#ps20001 (title: "add missing include")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Description was changed from ========== Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. Note: task_runner_util.h will be renamed to post_task_and_reply_with_result.h in a separate CL. BUG= ========== to ========== Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. Note: task_runner_util.h will be renamed to post_task_and_reply_with_result.h in a separate CL. BUG= TBR=sky@chromium.org ==========
fdoray@chromium.org changed reviewers: + sky@chromium.org
TBR sky@ for history_service.cc changes.
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2535843002/#ps40001 (title: "add missing header in history_service.cc")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
fdoray@chromium.org changed reviewers: + pkasting@chromium.org
Description was changed from ========== Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. Note: task_runner_util.h will be renamed to post_task_and_reply_with_result.h in a separate CL. BUG= TBR=sky@chromium.org ========== to ========== Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. Note: task_runner_util.h will be renamed to post_task_and_reply_with_result.h in a separate CL. BUG= TBR=sky@chromium.org,pkasting@chromium.org ==========
TBR pkasting for components/omnibox/browser/in_memory_url_index.cc
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2535843002/#ps60001 (title: "add missing header")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480520027700610, "parent_rev": "7ceacadd8f4c71061e7697f450f2991c2e2b6bad", "commit_rev": "a01a1e95f7a60ca610ca6b1814782356da8d114b"}
Message was sent while issue was closed.
Description was changed from ========== Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. Note: task_runner_util.h will be renamed to post_task_and_reply_with_result.h in a separate CL. BUG= TBR=sky@chromium.org,pkasting@chromium.org ========== to ========== Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. Note: task_runner_util.h will be renamed to post_task_and_reply_with_result.h in a separate CL. BUG= TBR=sky@chromium.org,pkasting@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. Note: task_runner_util.h will be renamed to post_task_and_reply_with_result.h in a separate CL. BUG= TBR=sky@chromium.org,pkasting@chromium.org ========== to ========== Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. Note: task_runner_util.h will be renamed to post_task_and_reply_with_result.h in a separate CL. BUG= TBR=sky@chromium.org,pkasting@chromium.org Committed: https://crrev.com/e94a9457a1bf46afa59c5678d1d2208e5eec7278 Cr-Commit-Position: refs/heads/master@{#435296} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e94a9457a1bf46afa59c5678d1d2208e5eec7278 Cr-Commit-Position: refs/heads/master@{#435296}
Message was sent while issue was closed.
LGTM |