Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2535843002: Move PostTaskAndReplyWithResult() adapters to a separate header. (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
Peter Kasting, sky, dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PostTaskAndReplyWithResult() adapters to a separate header. This will allow base::PostTaskAndReplyWithResult() adapters to be re-used from base/task_scheduler/post_task.h without indirectly including the declaration of base::PostTaskAndReplyWithResult() in every file that includes base/task_scheduler/post_task.h. Note: task_runner_util.h will be renamed to post_task_and_reply_with_result.h in a separate CL. BUG= TBR=sky@chromium.org,pkasting@chromium.org Committed: https://crrev.com/e94a9457a1bf46afa59c5678d1d2208e5eec7278 Cr-Commit-Position: refs/heads/master@{#435296}

Patch Set 1 #

Patch Set 2 : add missing include #

Patch Set 3 : add missing header in history_service.cc #

Patch Set 4 : add missing header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -20 lines) Patch
M base/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A base/post_task_and_reply_with_result_internal.h View 1 chunk +35 lines, -0 lines 0 comments Download
M base/task/cancelable_task_tracker.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M base/task_runner_util.h View 1 chunk +1 line, -19 lines 0 comments Download
M components/history/core/browser/history_service.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/browser/in_memory_url_index.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 38 (21 generated)
fdoray
PTAL
4 years ago (2016-11-29 16:03:50 UTC) #2
dcheng
LGTM Feels a bit weird IMO, but I don't see a good reason not to ...
4 years ago (2016-11-29 21:21:33 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2530223002 Patch 40001). Please resolve the dependency and ...
4 years ago (2016-11-29 21:40:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535843002/1
4 years ago (2016-11-30 13:36:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/44269) blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years ago (2016-11-30 13:42:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535843002/20001
4 years ago (2016-11-30 13:59:06 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/115554)
4 years ago (2016-11-30 14:09:52 UTC) #16
fdoray
TBR sky@ for history_service.cc changes.
4 years ago (2016-11-30 14:54:54 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535843002/40001
4 years ago (2016-11-30 14:55:15 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/115577)
4 years ago (2016-11-30 15:06:11 UTC) #24
fdoray
4 years ago (2016-11-30 15:33:22 UTC) #26
fdoray
TBR pkasting for components/omnibox/browser/in_memory_url_index.cc
4 years ago (2016-11-30 15:33:43 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535843002/60001
4 years ago (2016-11-30 15:34:10 UTC) #31
sky
LGTM
4 years ago (2016-11-30 16:29:45 UTC) #32
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-30 16:59:48 UTC) #35
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e94a9457a1bf46afa59c5678d1d2208e5eec7278 Cr-Commit-Position: refs/heads/master@{#435296}
4 years ago (2016-11-30 17:05:04 UTC) #37
Peter Kasting
4 years ago (2016-11-30 19:08:01 UTC) #38
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698