Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2528193002: Remove FileUtilProxy:DeleteFile(). (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
CC:
chromium-reviews, grt+watch_chromium.org, vmpstr+watch_chromium.org, Jialiu Lin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FileUtilProxy:DeleteFile(). FileUtilProxy::DeleteFile() deletes a file on a TaskRunner and then invokes a callback on the source thread. All call sites provide a null callback. They might as well just post a base::DeleteFile() task to the TaskRunner. This is a prerequisite to stop allowing null callbacks in base::PostTaskAndReplyWithResult(). BUG=162712 Committed: https://crrev.com/77c90085e7d90307d637256d0cb02718ab264c0a Cr-Commit-Position: refs/heads/master@{#434765}

Patch Set 1 #

Patch Set 2 : fix build error #

Patch Set 3 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -46 lines) Patch
M base/files/file_util_proxy.h View 1 chunk +0 lines, -8 lines 0 comments Download
M base/files/file_util_proxy.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback_service.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/libgtkui/print_dialog_gtk.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (17 generated)
fdoray
PTAL
4 years ago (2016-11-28 15:31:04 UTC) #14
dcheng
lgtm
4 years ago (2016-11-28 17:28:48 UTC) #15
fdoray
nparker@chromium.org: Please review changes in chrome/browser/safe_browsing erg@chromium.org: Please review changes in chrome/browser/ui/libgtkui/
4 years ago (2016-11-28 17:46:26 UTC) #17
Elliot Glaysher
lgtm
4 years ago (2016-11-28 18:08:44 UTC) #18
Nathan Parker
lgtm
4 years ago (2016-11-28 18:26:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528193002/40001
4 years ago (2016-11-28 18:33:14 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-28 23:06:23 UTC) #23
commit-bot: I haz the power
4 years ago (2016-11-28 23:10:40 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/77c90085e7d90307d637256d0cb02718ab264c0a
Cr-Commit-Position: refs/heads/master@{#434765}

Powered by Google App Engine
This is Rietveld 408576698