Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2530213002: Removed resetting of pinch-gesture filter state on pinch end. (Closed)

Created:
4 years ago by mustaq
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Removed resetting of pinch-gesture filter state on pinch end. We used to reset the TouchActionFilter state |drop_pinch_gesture_events_| at a pinch end assuming that there is a single pinch-sequence within a gesture-scroll sequence. This logically correct assumption turned out to be wrong in practice: a pinch-zoom-out-then-zoom-in actually sends two consecutive pinch-begin/end sequences between a gesture-scroll-begin/end sequence. This CL defers the resetting of |drop_pinch_gesture_events_| to bracketing gesture-scroll-end to avoid wrong filtering during the second pinch-begin/end sequence. BUG=662047 Review-Url: https://codereview.chromium.org/2526433003 Cr-Commit-Position: refs/heads/master@{#434248} (cherry picked from commit b8dc459398704fe6df59e1be0655399085454449) Committed: https://chromium.googlesource.com/chromium/src/+/b51fc4e484f4d46830b40122b04119e0edda708d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/browser/renderer_host/input/touch_action_filter.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/touch_action_filter_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mustaq
4 years ago (2016-11-25 16:20:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b51fc4e484f4d46830b40122b04119e0edda708d.

Powered by Google App Engine
This is Rietveld 408576698