Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: content/browser/renderer_host/input/touch_action_filter.cc

Issue 2530213002: Removed resetting of pinch-gesture filter state on pinch end. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/input/touch_action_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/input/touch_action_filter.cc
diff --git a/content/browser/renderer_host/input/touch_action_filter.cc b/content/browser/renderer_host/input/touch_action_filter.cc
index 19c1ce700670e86a4e34d2a664fea14079090121..d2bae4e003b0f3d7bca915b79b95b00cf92e0ca2 100644
--- a/content/browser/renderer_host/input/touch_action_filter.cc
+++ b/content/browser/renderer_host/input/touch_action_filter.cc
@@ -96,11 +96,11 @@ bool TouchActionFilter::FilterGestureEvent(WebGestureEvent* gesture_event) {
return drop_pinch_gesture_events_;
case WebInputEvent::GesturePinchEnd:
- if (drop_pinch_gesture_events_) {
- drop_pinch_gesture_events_ = false;
- return true;
- }
- break;
+ // TODO(mustaq): Don't reset drop_pinch_gesture_events_ here because a
+ // pinch-zoom-out-then-zoom-in sends two separate pinch sequences within a
+ // single gesture-scroll sequence, see crbug.com/662047#c13. Is it
+ // expected?
+ return drop_pinch_gesture_events_;
// The double tap gesture is a tap ending event. If a double tap gesture is
// filtered out, replace it with a tap event.
« no previous file with comments | « no previous file | content/browser/renderer_host/input/touch_action_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698