Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2526433003: Removed resetting of pinch-gesture filter state on pinch end. (Closed)

Created:
4 years, 1 month ago by mustaq
Modified:
4 years ago
Reviewers:
dtapuska
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed resetting of pinch-gesture filter state on pinch end. We used to reset the TouchActionFilter state |drop_pinch_gesture_events_| at a pinch end assuming that there is a single pinch-sequence within a gesture-scroll sequence. This logically correct assumption turned out to be wrong in practice: a pinch-zoom-out-then-zoom-in actually sends two consecutive pinch-begin/end sequences between a gesture-scroll-begin/end sequence. This CL defers the resetting of |drop_pinch_gesture_events_| to bracketing gesture-scroll-end to avoid wrong filtering during the second pinch-begin/end sequence. BUG=662047 Committed: https://crrev.com/b8dc459398704fe6df59e1be0655399085454449 Cr-Commit-Position: refs/heads/master@{#434248}

Patch Set 1 : WIP logs #

Patch Set 2 : Removed resetting of pinch-gesture filter state on pinch end. #

Patch Set 3 : Updated a unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/browser/renderer_host/input/touch_action_filter.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/touch_action_filter_unittest.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mustaq
ptal
4 years ago (2016-11-23 19:32:29 UTC) #4
dtapuska
On 2016/11/23 19:32:29, mustaq wrote: > ptal lgtm
4 years ago (2016-11-23 19:53:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526433003/60001
4 years ago (2016-11-23 19:57:54 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-11-23 21:13:44 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-23 21:16:25 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b8dc459398704fe6df59e1be0655399085454449
Cr-Commit-Position: refs/heads/master@{#434248}

Powered by Google App Engine
This is Rietveld 408576698