chrome: Cleanup class/struct forward declarations

chrome: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in chrome header files.

TBR=dbeam@chromium.org
BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/8aa3c277b9c99f6270e7c8e1dcbede0729595b0b
Cr-Commit-Position: refs/heads/master@{#434584}

[jbriance, 2016-11-25 10:59:14]

Description was changed from

==========
chrome: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in chrome header files.

BUG=662195
==========

to

==========
chrome: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in chrome header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[jbriance, 2016-11-25 11:01:03]

jbriance@cisco.com changed reviewers:
+ jochen@chromium.org, sky@chromium.org, thakis@chromium.org

[fs, 2016-11-25 12:25:36]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 12:25:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 12:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 12:43:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbriance, 2016-11-25 13:29:26]

jbriance@cisco.com changed reviewers:
+ bshe@chromium.org, dbeam@chromium.org

[jbriance, 2016-11-25 13:29:28]

+ dbeam and bshe

[fs, 2016-11-25 13:32:19]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 13:32:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 13:54:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 13:54:08]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[bshe, 2016-11-25 15:19:43]

On 2016/11/25 13:29:28, jbriance wrote:
> + dbeam and bshe

lgtm for wallpaper, vr_shell and virtual keyboard

[jbriance, 2016-11-25 15:55:11]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 15:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 16:04:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 16:04:39]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jbriance, 2016-11-25 16:13:04]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 16:13:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 16:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 16:53:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbriance, 2016-11-25 17:01:08]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 17:01:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 19:48:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 19:48:42]

Dry run: This issue passed the CQ dry run.

[jbriance, 2016-11-25 21:36:21]

Once properly reviewed, I think I'll need help from a committer to land this
one. It's pretty huge and might need to be rebased often.

[Nico, 2016-11-26 04:55:21]

lgtm

The tree is currently not very busy, so you might be able to land this with the
cq I think.

https://codereview.chromium.org/2530053003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
(right):

https://codereview.chromium.org/2530053003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc:344:
AvatarMenuButton* menu_button_ = nullptr;
this looks unused

(adding a class declaration instead of a definition in a cc file is suspect,
which is how i noticed)

[jbriance, 2016-11-26 10:21:36]

jbriance@cisco.com changed reviewers:
- fs@opera.com, jochen@chromium.org, sky@chromium.org

[jbriance, 2016-11-26 10:21:40]

- jochen, sky, and fs

dbeam, could you please review:
  chrome/browser/ui/webui/browsing_history_handler.h
  chrome/browser/ui/webui/history_ui.h
  chrome/browser/ui/webui/options/browser_options_handler.h
  chrome/browser/ui/webui/options/chromeos/internet_options_handler.h
  chrome/browser/ui/webui/options/password_manager_handler.h
  chrome/browser/ui/webui/options/preferences_browsertest.h
  chrome/browser/ui/webui/options/startup_pages_handler.h
  chrome/browser/ui/webui/options/sync_setup_handler.h

https://codereview.chromium.org/2530053003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
(right):

https://codereview.chromium.org/2530053003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc:344:
AvatarMenuButton* menu_button_ = nullptr;
On 2016/11/26 04:55:21, Nico wrote:
> this looks unused
> 
> (adding a class declaration instead of a definition in a cc file is suspect,
> which is how i noticed)

Indeed, good catch !

[jbriance, 2016-11-26 10:22:00]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-26 10:22:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-26 13:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-26 13:18:49]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-11-26 17:19:53]

I think my lg covers everything in chrome/

On Nov 26, 2016 5:21 AM, <jbriance@cisco.com> wrote:

> - jochen, sky, and fs
>
> dbeam, could you please review:
> chrome/browser/ui/webui/browsing_history_handler.h
> chrome/browser/ui/webui/history_ui.h
> chrome/browser/ui/webui/options/browser_options_handler.h
> chrome/browser/ui/webui/options/chromeos/internet_options_handler.h
> chrome/browser/ui/webui/options/password_manager_handler.h
> chrome/browser/ui/webui/options/preferences_browsertest.h
> chrome/browser/ui/webui/options/startup_pages_handler.h
> chrome/browser/ui/webui/options/sync_setup_handler.h
>
>
>
> https://codereview.chromium.org/2530053003/diff/80001/
> chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
> File
> chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
> (right):
>
> https://codereview.chromium.org/2530053003/diff/80001/
> chrome/browser/ui/views/frame/opaque_browser_frame_view_
> layout_unittest.cc#newcode344
> chrome/browser/ui/views/frame/opaque_browser_frame_view_
> layout_unittest.cc:344:
> AvatarMenuButton* menu_button_ = nullptr;
> On 2016/11/26 04:55:21, Nico wrote:
> > this looks unused
> >
> > (adding a class declaration instead of a definition in a cc file is
> suspect,
> > which is how i noticed)
>
> Indeed, good catch !
>
> https://codereview.chromium.org/2530053003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Nico, 2016-11-26 17:19:56]

I think my lg covers everything in chrome/

On Nov 26, 2016 5:21 AM, <jbriance@cisco.com> wrote:

> - jochen, sky, and fs
>
> dbeam, could you please review:
> chrome/browser/ui/webui/browsing_history_handler.h
> chrome/browser/ui/webui/history_ui.h
> chrome/browser/ui/webui/options/browser_options_handler.h
> chrome/browser/ui/webui/options/chromeos/internet_options_handler.h
> chrome/browser/ui/webui/options/password_manager_handler.h
> chrome/browser/ui/webui/options/preferences_browsertest.h
> chrome/browser/ui/webui/options/startup_pages_handler.h
> chrome/browser/ui/webui/options/sync_setup_handler.h
>
>
>
> https://codereview.chromium.org/2530053003/diff/80001/
> chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
> File
> chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
> (right):
>
> https://codereview.chromium.org/2530053003/diff/80001/
> chrome/browser/ui/views/frame/opaque_browser_frame_view_
> layout_unittest.cc#newcode344
> chrome/browser/ui/views/frame/opaque_browser_frame_view_
> layout_unittest.cc:344:
> AvatarMenuButton* menu_button_ = nullptr;
> On 2016/11/26 04:55:21, Nico wrote:
> > this looks unused
> >
> > (adding a class declaration instead of a definition in a cc file is
> suspect,
> > which is how i noticed)
>
> Indeed, good catch !
>
> https://codereview.chromium.org/2530053003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jbriance, 2016-11-26 17:25:51]

The CQ bit was checked by jbriance@cisco.com

[jbriance, 2016-11-26 17:25:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2530053003/#ps100001
(title: "Rebase + address comment")

[commit-bot: I haz the power, 2016-11-26 17:26:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbriance, 2016-11-26 17:44:13]

On 2016/11/26 17:19:56, Nico wrote:
> I think my lg covers everything in chrome/

It seems that presubmit bot does not agree :)

 ** Presubmit ERRORS **
 Missing LGTM from an OWNER for these files:
     chrome/browser/ui/webui/browsing_history_handler.h
     chrome/browser/ui/webui/history_ui.h
     chrome/browser/ui/webui/options/browser_options_handler.h
     chrome/browser/ui/webui/options/chromeos/internet_options_handler.h
     chrome/browser/ui/webui/options/password_manager_handler.h
     chrome/browser/ui/webui/options/preferences_browsertest.h
     chrome/browser/ui/webui/options/startup_pages_handler.h
     chrome/browser/ui/webui/options/sync_setup_handler.h

[commit-bot: I haz the power, 2016-11-26 17:46:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-26 17:46:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2016-11-26 20:08:03]

Huh, that's a bug in the OWNERS file then, probably. But yeah, you need to
wait for dream then, sorry :-/

On Nov 26, 2016 12:44 PM, <jbriance@cisco.com> wrote:

> On 2016/11/26 17:19:56, Nico wrote:
> > I think my lg covers everything in chrome/
>
> It seems that presubmit bot does not agree :)
>
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
> chrome/browser/ui/webui/browsing_history_handler.h
> chrome/browser/ui/webui/history_ui.h
> chrome/browser/ui/webui/options/browser_options_handler.h
> chrome/browser/ui/webui/options/chromeos/internet_options_handler.h
> chrome/browser/ui/webui/options/password_manager_handler.h
> chrome/browser/ui/webui/options/preferences_browsertest.h
> chrome/browser/ui/webui/options/startup_pages_handler.h
> chrome/browser/ui/webui/options/sync_setup_handler.h
>
>
>
> https://codereview.chromium.org/2530053003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Nico, 2016-11-26 20:08:04]

Huh, that's a bug in the OWNERS file then, probably. But yeah, you need to
wait for dream then, sorry :-/

On Nov 26, 2016 12:44 PM, <jbriance@cisco.com> wrote:

> On 2016/11/26 17:19:56, Nico wrote:
> > I think my lg covers everything in chrome/
>
> It seems that presubmit bot does not agree :)
>
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
> chrome/browser/ui/webui/browsing_history_handler.h
> chrome/browser/ui/webui/history_ui.h
> chrome/browser/ui/webui/options/browser_options_handler.h
> chrome/browser/ui/webui/options/chromeos/internet_options_handler.h
> chrome/browser/ui/webui/options/password_manager_handler.h
> chrome/browser/ui/webui/options/preferences_browsertest.h
> chrome/browser/ui/webui/options/startup_pages_handler.h
> chrome/browser/ui/webui/options/sync_setup_handler.h
>
>
>
> https://codereview.chromium.org/2530053003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dcheng, 2016-11-26 20:10:24]

On 2016/11/26 20:08:04, Nico wrote:
> Huh, that's a bug in the OWNERS file then, probably. But yeah, you need to
> wait for dream then, sorry :-/
> 
> On Nov 26, 2016 12:44 PM, <mailto:jbriance@cisco.com> wrote:
> 
> > On 2016/11/26 17:19:56, Nico wrote:
> > > I think my lg covers everything in chrome/
> >
> > It seems that presubmit bot does not agree :)
> >
> > ** Presubmit ERRORS **
> > Missing LGTM from an OWNER for these files:
> > chrome/browser/ui/webui/browsing_history_handler.h
> > chrome/browser/ui/webui/history_ui.h
> > chrome/browser/ui/webui/options/browser_options_handler.h
> > chrome/browser/ui/webui/options/chromeos/internet_options_handler.h
> > chrome/browser/ui/webui/options/password_manager_handler.h
> > chrome/browser/ui/webui/options/preferences_browsertest.h
> > chrome/browser/ui/webui/options/startup_pages_handler.h
> > chrome/browser/ui/webui/options/sync_setup_handler.h
> >
> >
> >
> > https://codereview.chromium.org/2530053003/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Yeah, parts of webui are noparent for Reasons.

TBH, I think a TBR is reasonable here.

[jbriance, 2016-11-27 09:00:24]

Description was changed from

==========
chrome: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in chrome header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
chrome: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in chrome header files.

TBR=dbeam@chromium.org
BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[jbriance, 2016-11-27 09:00:56]

The CQ bit was checked by jbriance@cisco.com

[commit-bot: I haz the power, 2016-11-27 09:01:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbriance, 2016-11-27 09:03:16]

On 2016/11/26 20:10:24, dcheng wrote:
>
> TBH, I think a TBR is reasonable here.

Thanks, I didn't know about TBR before, and I also think this is a right
opportunity to use it :)

[commit-bot: I haz the power, 2016-11-27 09:21:22]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480237256163950,
"parent_rev": "205d3f42158bbb08d270047efbf84fab26fb3815", "commit_rev":
"5c4a99c7098dd2fb4bf3498391aa3eb311fbe403"}

[commit-bot: I haz the power, 2016-11-27 09:22:02]

Description was changed from

==========
chrome: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in chrome header files.

TBR=dbeam@chromium.org
BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
chrome: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in chrome header files.

TBR=dbeam@chromium.org
BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[commit-bot: I haz the power, 2016-11-27 09:22:07]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-27 09:24:04]

Description was changed from

==========
chrome: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in chrome header files.

TBR=dbeam@chromium.org
BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
chrome: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in chrome header files.

TBR=dbeam@chromium.org
BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/8aa3c277b9c99f6270e7c8e1dcbede0729595b0b
Cr-Commit-Position: refs/heads/master@{#434584}
==========

[commit-bot: I haz the power, 2016-11-27 09:24:10]

Patchset 6 (id:??) landed as
https://crrev.com/8aa3c277b9c99f6270e7c8e1dcbede0729595b0b
Cr-Commit-Position: refs/heads/master@{#434584}

[Lei Zhang, 2016-11-28 18:11:05]

On 2016/11/26 20:08:04, Nico wrote:
> Huh, that's a bug in the OWNERS file then, probably. But yeah, you need to
> wait for dream then, sorry :-/

s/dream/dbeam/

It's not a bug. That directory has "set noparent" in its OWNERS file.

[Nico, 2016-11-28 18:14:47]

On Mon, Nov 28, 2016 at 1:11 PM, <thestig@chromium.org> wrote:

> On 2016/11/26 20:08:04, Nico wrote:
> > Huh, that's a bug in the OWNERS file then, probably. But yeah, you need
> to
> > wait for dream then, sorry :-/
>
> s/dream/dbeam/
>
> It's not a bug. That directory has "set noparent" in its OWNERS file.
>

That's the bug :-)


>
> https://codereview.chromium.org/2530053003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Nico, 2016-11-28 18:14:47]

On Mon, Nov 28, 2016 at 1:11 PM, <thestig@chromium.org> wrote:

> On 2016/11/26 20:08:04, Nico wrote:
> > Huh, that's a bug in the OWNERS file then, probably. But yeah, you need
> to
> > wait for dream then, sorry :-/
>
> s/dream/dbeam/
>
> It's not a bug. That directory has "set noparent" in its OWNERS file.
>

That's the bug :-)


>
> https://codereview.chromium.org/2530053003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dan Beam, 2016-11-29 05:27:19]

On 2016/11/26 20:10:24, dcheng wrote:
> On 2016/11/26 20:08:04, Nico wrote:
> > Huh, that's a bug in the OWNERS file then, probably. But yeah, you need to
> > wait for dream then, sorry :-/
> > 
> > On Nov 26, 2016 12:44 PM, <mailto:jbriance@cisco.com> wrote:
> > 
> > > On 2016/11/26 17:19:56, Nico wrote:
> > > > I think my lg covers everything in chrome/
> > >
> > > It seems that presubmit bot does not agree :)
> > >
> > > ** Presubmit ERRORS **
> > > Missing LGTM from an OWNER for these files:
> > > chrome/browser/ui/webui/browsing_history_handler.h
> > > chrome/browser/ui/webui/history_ui.h
> > > chrome/browser/ui/webui/options/browser_options_handler.h
> > > chrome/browser/ui/webui/options/chromeos/internet_options_handler.h
> > > chrome/browser/ui/webui/options/password_manager_handler.h
> > > chrome/browser/ui/webui/options/preferences_browsertest.h
> > > chrome/browser/ui/webui/options/startup_pages_handler.h
> > > chrome/browser/ui/webui/options/sync_setup_handler.h
> > >
> > >
> > >
> > > https://codereview.chromium.org/2530053003/
> > >
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> Yeah, parts of webui are noparent for Reasons.
> 
> TBH, I think a TBR is reasonable here.

yep, there's a note about this in the OWNERS files.  both sets of code (history
and options) are deprecated.  sorry that changes like this might've been slowed
down by a TBR=, but I definitely agree it was reasonable.

[Dan Beam, 2016-11-29 05:30:25]

lgtm