chrome: Cleanup class/struct forward declarations

chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h"
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/layout_constants.h"
@@ skipping 19 matching lines @@
     views::NonClientFrameView::kClientEdgeThickness;
 const int kMinimizeButtonWidth = 26;
 const int kMaximizeButtonWidth = 25;
 const int kCloseButtonWidth = 43;
 const int kMaximizedExtraCloseWidth = OBFVL::kFrameBorderThickness -
     views::NonClientFrameView::kFrameShadowThickness;
 const int kCaptionButtonsWidth =
     kMinimizeButtonWidth + kMaximizeButtonWidth + kCloseButtonWidth;
 const int kCaptionButtonHeight = 18;
 
+class AvatarMenuButton;
+
 class TestLayoutDelegate : public OpaqueBrowserFrameViewLayoutDelegate {
  public:
   TestLayoutDelegate() : show_caption_buttons_(true), maximized_(false) {}
   ~TestLayoutDelegate() override {}
 
   void set_window_title(const base::string16& title) { window_title_ = title; }
   void set_show_caption_buttons(bool show_caption_buttons) {
     show_caption_buttons_ = show_caption_buttons;
   }
   void set_maximized(bool maximized) { maximized_ = maximized; }
@@ skipping 282 matching lines @@
 
   // Widgets:
   views::ImageButton* minimize_button_ = nullptr;
   views::ImageButton* maximize_button_ = nullptr;
   views::ImageButton* restore_button_ = nullptr;
   views::ImageButton* close_button_ = nullptr;
 
   TabIconView* tab_icon_view_ = nullptr;
   views::Label* window_title_ = nullptr;
 
   AvatarMenuButton* menu_button_ = nullptr;

[Nico, 2016/11/26 04:55:21]

this looks unused

(adding a class declaration instead of a definition in a cc file is suspect,
which is how i noticed)

[jbriance, 2016/11/26 10:21:40]

Indeed, good catch !

   views::MenuButton* avatar_button_ = nullptr;
 
   DISALLOW_COPY_AND_ASSIGN(OpaqueBrowserFrameViewLayoutTest);
 };
 
 TEST_F(OpaqueBrowserFrameViewLayoutTest, BasicWindow) {
   // Tests the layout of a default chrome window with no avatars, no window
   // titles, and a tabstrip.
 
   for (int i = 0; i < 2; ++i) {
@@ skipping 73 matching lines @@
 
   for (int i = 0; i < 2; ++i) {
     root_view_->Layout();
     SCOPED_TRACE(i == 0 ? "Window is restored" : "Window is maximized");
     ExpectCaptionButtons(false, 0);
     ExpectTabStripAndMinimumSize(false);
     ExpectAvatar();
     delegate_->set_maximized(true);
   }
 }