Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_util.h

Issue 2530053003: chrome: Cleanup class/struct forward declarations (Closed)
Patch Set: Rebase + address comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_UTIL_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_UTIL_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_UTIL_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_UTIL_H_
7 7
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/optional.h" 9 #include "base/optional.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 11
12 #define PAGE_LOAD_HISTOGRAM(name, sample) \ 12 #define PAGE_LOAD_HISTOGRAM(name, sample) \
13 UMA_HISTOGRAM_CUSTOM_TIMES(name, sample, \ 13 UMA_HISTOGRAM_CUSTOM_TIMES(name, sample, \
14 base::TimeDelta::FromMilliseconds(10), \ 14 base::TimeDelta::FromMilliseconds(10), \
15 base::TimeDelta::FromMinutes(10), 100) 15 base::TimeDelta::FromMinutes(10), 100)
16 16
17 namespace page_load_metrics { 17 namespace page_load_metrics {
18 18
19 struct PageLoadExtraInfo; 19 struct PageLoadExtraInfo;
20 struct PageLoadTiming;
21 20
22 // Returns true if: 21 // Returns true if:
23 // - We have timing information for the event. 22 // - We have timing information for the event.
24 // - The page load started while the page was in the foreground. 23 // - The page load started while the page was in the foreground.
25 // - The event occurred prior to the page being moved to the background. 24 // - The event occurred prior to the page being moved to the background.
26 // When a page is backgrounded, some events (e.g. paint) are delayed. Since 25 // When a page is backgrounded, some events (e.g. paint) are delayed. Since
27 // these data points can skew the mean, they should not be mixed with timing 26 // these data points can skew the mean, they should not be mixed with timing
28 // events that occurred in the foreground. 27 // events that occurred in the foreground.
29 // If the event time delta and background time delta are equal, we still 28 // If the event time delta and background time delta are equal, we still
30 // consider the event to be logged in the foreground histogram since any 29 // consider the event to be logged in the foreground histogram since any
31 // background specific handling would not yet have been applied to that event. 30 // background specific handling would not yet have been applied to that event.
32 bool WasStartedInForegroundOptionalEventInForeground( 31 bool WasStartedInForegroundOptionalEventInForeground(
33 const base::Optional<base::TimeDelta>& event, 32 const base::Optional<base::TimeDelta>& event,
34 const PageLoadExtraInfo& info); 33 const PageLoadExtraInfo& info);
35 34
36 } // namespace page_load_metrics 35 } // namespace page_load_metrics
37 36
38 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_UTIL_H_ 37 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_UTIL_H_
OLDNEW
« no previous file with comments | « chrome/browser/notifications/notifier_source.h ('k') | chrome/browser/password_manager/chrome_password_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698