[Heap] Remove concept of MarkingParity.

[Heap] Remove concept of MarkingParity.

MarkingParity was used to avoid performing an operation on an object if it was
marked multiple times. We no longer mark things multiple times, so this concept
is no longer required.

BUG=chromium:666275
Committed: https://crrev.com/5fd2b71236e59e1cea95f23106de072865bd4857
Cr-Commit-Position: refs/heads/master@{#41354}

[rmcilroy, 2016-11-25 20:52:12]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 20:52:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-11-25 20:52:29]

rmcilroy@chromium.org changed reviewers:
+ hpayer@chromium.org

[rmcilroy, 2016-11-25 20:52:29]

Hannes, PTAL, thanks.

[commit-bot: I haz the power, 2016-11-25 20:55:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 20:55:48]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/16842)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/18569)

[rmcilroy, 2016-11-25 21:02:23]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2016-11-25 21:02:28]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 21:02:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 21:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 21:05:28]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/18455)

[rmcilroy, 2016-11-25 21:10:50]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 21:10:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 21:14:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 21:14:05]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)

[rmcilroy, 2016-11-25 22:16:46]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 22:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 22:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 22:44:59]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-11-28 09:49:10]

LGTM

https://codereview.chromium.org/2529173002/diff/60001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):

https://codereview.chromium.org/2529173002/diff/60001/src/arm/codegen-arm.cc#...
src/arm/codegen-arm.cc:446: } else {
Remove the else case (also in the other codegen-* implementations).

[rmcilroy, 2016-11-28 10:06:24]

https://codereview.chromium.org/2529173002/diff/60001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):

https://codereview.chromium.org/2529173002/diff/60001/src/arm/codegen-arm.cc#...
src/arm/codegen-arm.cc:446: } else {
On 2016/11/28 09:49:10, Hannes Payer wrote:
> Remove the else case (also in the other codegen-* implementations).

Not sure what you mean by this. I can't remove the else case since it is still
used. Do you mean do an early return on the if (IsYoungSequence) and fall
through to the other case?

[rmcilroy, 2016-11-29 10:10:30]

On 2016/11/28 10:06:24, rmcilroy wrote:
> https://codereview.chromium.org/2529173002/diff/60001/src/arm/codegen-arm.cc
> File src/arm/codegen-arm.cc (right):
> 
>
https://codereview.chromium.org/2529173002/diff/60001/src/arm/codegen-arm.cc#...
> src/arm/codegen-arm.cc:446: } else {
> On 2016/11/28 09:49:10, Hannes Payer wrote:
> > Remove the else case (also in the other codegen-* implementations).
> 
> Not sure what you mean by this. I can't remove the else case since it is still
> used. Do you mean do an early return on the if (IsYoungSequence) and fall
> through to the other case?

Ping Hannes?

[Hannes Payer (out of office), 2016-11-29 10:19:24]

On 2016/11/29 10:10:30, rmcilroy wrote:
> On 2016/11/28 10:06:24, rmcilroy wrote:
> > https://codereview.chromium.org/2529173002/diff/60001/src/arm/codegen-arm.cc
> > File src/arm/codegen-arm.cc (right):
> > 
> >
>
https://codereview.chromium.org/2529173002/diff/60001/src/arm/codegen-arm.cc#...
> > src/arm/codegen-arm.cc:446: } else {
> > On 2016/11/28 09:49:10, Hannes Payer wrote:
> > > Remove the else case (also in the other codegen-* implementations).
> > 
> > Not sure what you mean by this. I can't remove the else case since it is
still
> > used. Do you mean do an early return on the if (IsYoungSequence) and fall
> > through to the other case?
> 
> Ping Hannes?

yes, this is what I meant. sorry for the confusion.

[rmcilroy, 2016-11-29 11:42:02]

https://codereview.chromium.org/2529173002/diff/60001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):

https://codereview.chromium.org/2529173002/diff/60001/src/arm/codegen-arm.cc#...
src/arm/codegen-arm.cc:446: } else {
On 2016/11/28 10:06:24, rmcilroy wrote:
> On 2016/11/28 09:49:10, Hannes Payer wrote:
> > Remove the else case (also in the other codegen-* implementations).
> 
> Not sure what you mean by this. I can't remove the else case since it is still
> used. Do you mean do an early return on the if (IsYoungSequence) and fall
> through to the other case?

Done.

[rmcilroy, 2016-11-29 11:42:51]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-11-29 11:42:51]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2529173002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-29 11:43:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 12:09:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480419771418250,
"parent_rev": "fbb5b3ce4779f5f53d41075d3135716cd07e137f", "commit_rev":
"56362c7e746f27263d596052d69c9bb87e2243dc"}

[commit-bot: I haz the power, 2016-11-29 12:10:02]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-11-29 12:10:21]

Description was changed from

==========
[Heap] Remove concept of MarkingParity.

MarkingParity was used to avoid performing an operation on an object if it was
marked multiple times. We no longer mark things multiple times, so this concept
is no longer required.

BUG=chromium:666275
==========

to

==========
[Heap] Remove concept of MarkingParity.

MarkingParity was used to avoid performing an operation on an object if it was
marked multiple times. We no longer mark things multiple times, so this concept
is no longer required.

BUG=chromium:666275

Committed: https://crrev.com/5fd2b71236e59e1cea95f23106de072865bd4857
Cr-Commit-Position: refs/heads/master@{#41354}
==========

[commit-bot: I haz the power, 2016-11-29 12:10:21]

Patchset 5 (id:??) landed as
https://crrev.com/5fd2b71236e59e1cea95f23106de072865bd4857
Cr-Commit-Position: refs/heads/master@{#41354}

[Michael Starzinger, 2016-11-29 12:23:30]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-11-29 12:23:31]

Woot! +1, huge fan of removing this. Thanks!