[Heap] Remove concept of MarkingParity.

src/arm/codegen-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/arm/codegen-arm.h"
 
 #if V8_TARGET_ARCH_ARM
 
 #include <memory>
 
@@ skipping 422 matching lines @@
 }
 #endif
 
 
 bool Code::IsYoungSequence(Isolate* isolate, byte* sequence) {
   bool result = isolate->code_aging_helper()->IsYoung(sequence);
   DCHECK(result || isolate->code_aging_helper()->IsOld(sequence));
   return result;
 }
 
-
-void Code::GetCodeAgeAndParity(Isolate* isolate, byte* sequence, Age* age,
-                               MarkingParity* parity) {
+Code::Age Code::GetCodeAge(Isolate* isolate, byte* sequence) {
   if (IsYoungSequence(isolate, sequence)) {
-    *age = kNoAgeCodeAge;
-    *parity = NO_MARKING_PARITY;
+    return kNoAgeCodeAge;
   } else {

[Hannes Payer (out of office), 2016/11/28 09:49:10]

Remove the else case (also in the other codegen-* implementations).

[rmcilroy, 2016/11/28 10:06:24]

Not sure what you mean by this. I can't remove the else case since it is still
used. Do you mean do an early return on the if (IsYoungSequence) and fall
through to the other case?

[rmcilroy, 2016/11/29 11:42:02]

Done.

     Address target_address = Memory::Address_at(
         sequence + (kNoCodeAgeSequenceLength - Assembler::kInstrSize));
     Code* stub = GetCodeFromTargetAddress(target_address);
-    GetCodeAgeAndParity(stub, age, parity);
+    return GetAgeOfCodeAgeStub(stub);
   }
 }
 
-
-void Code::PatchPlatformCodeAge(Isolate* isolate,
-                                byte* sequence,
-                                Code::Age age,
-                                MarkingParity parity) {
+void Code::PatchPlatformCodeAge(Isolate* isolate, byte* sequence,
+                                Code::Age age) {
   uint32_t young_length = isolate->code_aging_helper()->young_sequence_length();
   if (age == kNoAgeCodeAge) {
     isolate->code_aging_helper()->CopyYoungSequenceTo(sequence);
     Assembler::FlushICache(isolate, sequence, young_length);
   } else {
-    Code* stub = GetCodeAgeStub(isolate, age, parity);
+    Code* stub = GetCodeAgeStub(isolate, age);
     CodePatcher patcher(isolate, sequence,
                         young_length / Assembler::kInstrSize);
     patcher.masm()->add(r0, pc, Operand(-8));
     patcher.masm()->ldr(pc, MemOperand(pc, -4));
     patcher.masm()->emit_code_stub_address(stub);
   }
 }
 
-
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_ARM