[Interpreter] Add bytecode aging and use it enable CompilationCache for bytecode

[Interpreter] Add bytecode aging and use it enable CompilationCache for bytecode

Adds a bytecode_age field to BytecodeArray objects. This is incremented each
time the bytecode array is marked by GC, and reset to zero if the bytecode
is executed.

This is used to enable the CompilationCache for interpreted functions,
where Interpreted entries are evicted once the bytecode becomes old.

BUG=chromium:666275, v8:4680
Committed: https://crrev.com/067e9e295fa50a3d4a5eb77e6515f30df944069f
Cr-Commit-Position: refs/heads/master@{#41356}

[rmcilroy, 2016-11-28 13:58:38]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 13:58:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-11-28 14:04:34]

rmcilroy@chromium.org changed reviewers:
+ hpayer@chromium.org, mstarzinger@chromium.org

[rmcilroy, 2016-11-28 14:04:35]

Hannes / Michi, PTAL. I'll port to other architectures if you are happy with the
overall approach.

[rmcilroy, 2016-11-28 14:21:28]

Patchset #1 (id:1) has been deleted

[Michael Starzinger, 2016-11-28 14:21:30]

LGTM from my end.

https://codereview.chromium.org/2534763003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2534763003/diff/20001/src/objects.cc#newcode1...
src/objects.cc:15184: DCHECK_LE(age, kLastBytecodeAge);
nit: Shouldn't these DCHECKs be applied on the _new_ age? Or alternatively I
would vote for moving them 3 lines up to before the new value is stored (for
readability).

[rmcilroy, 2016-11-28 14:29:04]

https://codereview.chromium.org/2534763003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2534763003/diff/20001/src/objects.cc#newcode1...
src/objects.cc:15184: DCHECK_LE(age, kLastBytecodeAge);
On 2016/11/28 14:21:30, Michael Starzinger wrote:
> nit: Shouldn't these DCHECKs be applied on the _new_ age? Or alternatively I
> would vote for moving them 3 lines up to before the new value is stored (for
> readability).

Yes the should, updated to check bytecode_age() instead

[rmcilroy, 2016-11-28 15:27:26]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 15:27:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 15:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 15:57:42]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-11-29 10:21:30]

lgtm

[rmcilroy, 2016-11-29 11:36:19]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-11-29 11:36:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2534763003/#ps60001
(title: "Add ports")

[commit-bot: I haz the power, 2016-11-29 11:36:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 11:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 11:37:52]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/17006)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/17059)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/16971)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/29569)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/18694)

[rmcilroy, 2016-11-29 11:45:41]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 11:45:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 12:12:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 12:12:48]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-11-29 12:32:25]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-11-29 12:32:25]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2534763003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-29 12:32:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 12:34:32]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480422745397610,
"parent_rev": "1aefa5b77e8a3641a21de3f1046660414aa9f494", "commit_rev":
"c6b50c257c4ef46f7632b722ac461b7ff3b95504"}

[commit-bot: I haz the power, 2016-11-29 12:34:36]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-29 12:35:08]

Description was changed from

==========
[Interpreter] Add bytecode aging and use it enable CompilationCache for bytecode

Adds a bytecode_age field to BytecodeArray objects. This is incremented each
time the bytecode array is marked by GC, and reset to zero if the bytecode
is executed.

This is used to enable the CompilationCache for interpreted functions,
where Interpreted entries are evicted once the bytecode becomes old.

BUG=chromium:666275,v8:4680
==========

to

==========
[Interpreter] Add bytecode aging and use it enable CompilationCache for bytecode

Adds a bytecode_age field to BytecodeArray objects. This is incremented each
time the bytecode array is marked by GC, and reset to zero if the bytecode
is executed.

This is used to enable the CompilationCache for interpreted functions,
where Interpreted entries are evicted once the bytecode becomes old.

BUG=chromium:666275,v8:4680

Committed: https://crrev.com/067e9e295fa50a3d4a5eb77e6515f30df944069f
Cr-Commit-Position: refs/heads/master@{#41356}
==========

[commit-bot: I haz the power, 2016-11-29 12:35:09]

Patchset 4 (id:??) landed as
https://crrev.com/067e9e295fa50a3d4a5eb77e6515f30df944069f
Cr-Commit-Position: refs/heads/master@{#41356}