Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5896)

Unified Diff: chrome/browser/ui/views/payments/view_stack_unittest.cc

Issue 2528503002: [WebPayments] Implement state transitions in desktop WebPayments dialog. (Closed)
Patch Set: Handle Layout while animating Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/payments/view_stack.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/payments/view_stack_unittest.cc
diff --git a/chrome/browser/ui/views/payments/view_stack_unittest.cc b/chrome/browser/ui/views/payments/view_stack_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5af591e27efe6d5cb7cb1595380ee0e719c8fbcf
--- /dev/null
+++ b/chrome/browser/ui/views/payments/view_stack_unittest.cc
@@ -0,0 +1,174 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/observer_list.h"
+#include "base/run_loop.h"
+#include "chrome/browser/ui/views/payments/view_stack.h"
+#include "ui/gfx/animation/test_animation_delegate.h"
+#include "ui/views/test/views_test_base.h"
+
+class TestStackView : public views::View {
+ public:
+ class Observer {
+ public:
+ Observer() : view_deleted_(false) {}
+
+ void OnViewBeingDeleted() {
+ view_deleted_ = true;
+ }
+
+ bool view_deleted() { return view_deleted_; }
+
+ private:
+ bool view_deleted_;
+ };
+
+ TestStackView() {}
+ ~TestStackView() override {
+ for (auto& observer: observers_) {
+ observer.OnViewBeingDeleted();
+ }
+ }
+
+ void AddObserver(Observer* observer) {
+ observers_.AddObserver(observer);
+ }
+
+ private:
+ base::ObserverList<Observer> observers_;
+
+ DISALLOW_COPY_AND_ASSIGN(TestStackView);
+};
+
+class ViewStackTest : public views::ViewsTestBase {
+ public:
+ ViewStackTest()
+ : view_stack_(base::MakeUnique<ViewStack>()) {
+ view_stack_->SetBounds(0, 0, 10, 10);
+ view_stack_->Push(base::MakeUnique<TestStackView>(), false);
+ view_stack_->slide_in_animator_->SetAnimationDuration(1);
+ view_stack_->slide_out_animator_->SetAnimationDuration(1);
+ }
+
+ void AssertViewOnTopOfStack(views::View* view) {
+ gfx::Rect target = view_stack_->bounds();
+ target.set_origin(gfx::Point(0, 0));
+ EXPECT_EQ(target, view->bounds());
+ }
+
+ void AssertViewCompletelyNextToStack(views::View* view) {
+ gfx::Rect target = view_stack_->bounds();
+ target.set_origin(gfx::Point(view_stack_->width(), 0));
+ EXPECT_EQ(target, view->bounds());
+ }
+
+ std::unique_ptr<ViewStack> view_stack_;
+
+ DISALLOW_COPY_AND_ASSIGN(ViewStackTest);
+};
+
+TEST_F(ViewStackTest, TestInitialStateAddedAsChildView) {
+ EXPECT_EQ(1, view_stack_->child_count());
+ // This child was added without any animation so it's on top of its parent
+ // already.
+ AssertViewOnTopOfStack(view_stack_->top());
+}
+
+TEST_F(ViewStackTest, TestPushStateAddsViewToChildren) {
+ view_stack_->Push(base::MakeUnique<TestStackView>(), true);
+ EXPECT_EQ(2, view_stack_->child_count());
+
+ AssertViewCompletelyNextToStack(view_stack_->top());
+}
+
+TEST_F(ViewStackTest, TestPopStateRemovesChildViewAndCleansUpState) {
+ TestStackView::Observer observer;
+ std::unique_ptr<TestStackView> view = base::MakeUnique<TestStackView>();
+ view->AddObserver(&observer);
+ views::View* view_ptr = view.get();
+
+ view_stack_->Push(std::move(view), true);
+ EXPECT_TRUE(view_stack_->slide_in_animator_->IsAnimating());
+ view_stack_->slide_in_animator_->SetAnimationDelegate(
+ view_ptr,
+ std::unique_ptr<gfx::AnimationDelegate>(
+ new gfx::TestAnimationDelegate()));
+
+ AssertViewCompletelyNextToStack(view_ptr);
+
+ base::RunLoop().Run();
+ AssertViewOnTopOfStack(view_ptr);
+ EXPECT_FALSE(view_stack_->slide_in_animator_->IsAnimating());
+ view_stack_->Pop();
+
+ EXPECT_TRUE(view_stack_->slide_out_animator_->IsAnimating());
+ view_stack_->slide_out_animator_->SetAnimationDelegate(
+ view_ptr,
+ std::unique_ptr<gfx::AnimationDelegate>(
+ new gfx::TestAnimationDelegate()));
+
+ base::RunLoop().Run();
+ EXPECT_FALSE(view_stack_->slide_out_animator_->IsAnimating());
+
+ ASSERT_TRUE(observer.view_deleted());
+}
+
+TEST_F(ViewStackTest, TestDeletingViewCleansUpState) {
+ TestStackView::Observer observer;
+ std::unique_ptr<TestStackView> view = base::MakeUnique<TestStackView>();
+ view->AddObserver(&observer);
+ views::View* view_ptr = view.get();
+
+ view_stack_->Push(std::move(view), true);
+ EXPECT_TRUE(view_stack_->slide_in_animator_->IsAnimating());
+ view_stack_->slide_in_animator_->SetAnimationDelegate(
+ view_ptr,
+ std::unique_ptr<gfx::AnimationDelegate>(
+ new gfx::TestAnimationDelegate()));
+
+ AssertViewCompletelyNextToStack(view_ptr);
+
+ base::RunLoop().Run();
+ AssertViewOnTopOfStack(view_ptr);
+ EXPECT_FALSE(view_stack_->slide_in_animator_->IsAnimating());
+ view_stack_->Pop();
+
+ EXPECT_TRUE(view_stack_->slide_out_animator_->IsAnimating());
+ view_stack_.reset();
+
+ ASSERT_TRUE(observer.view_deleted());
+}
+
+TEST_F(ViewStackTest, TestLayoutUpdatesAnimations) {
+ TestStackView::Observer observer;
+ std::unique_ptr<TestStackView> view = base::MakeUnique<TestStackView>();
+ view->AddObserver(&observer);
+ views::View* view_ptr = view.get();
+
+ view_stack_->Push(std::move(view), true);
+ EXPECT_TRUE(view_stack_->slide_in_animator_->IsAnimating());
+ view_stack_->slide_in_animator_->SetAnimationDelegate(
+ view_ptr,
+ std::unique_ptr<gfx::AnimationDelegate>(
+ new gfx::TestAnimationDelegate()));
+
+ view_stack_->SetBounds(10, 10, 30, 30);
+ view_stack_->Layout();
+
+ base::RunLoop().Run();
+ AssertViewOnTopOfStack(view_ptr);
+ EXPECT_FALSE(view_stack_->slide_in_animator_->IsAnimating());
+ view_stack_->Pop();
+
+ EXPECT_TRUE(view_stack_->slide_out_animator_->IsAnimating());
+ view_stack_->slide_out_animator_->SetAnimationDelegate(
+ view_ptr,
+ std::unique_ptr<gfx::AnimationDelegate>(
+ new gfx::TestAnimationDelegate()));
+
+ base::RunLoop().Run();
+ EXPECT_FALSE(view_stack_->slide_out_animator_->IsAnimating());
+
+ ASSERT_TRUE(observer.view_deleted());
+}
« no previous file with comments | « chrome/browser/ui/views/payments/view_stack.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698