Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: chrome/browser/ui/views/payments/view_stack_unittest.cc

Issue 2528503002: [WebPayments] Implement state transitions in desktop WebPayments dialog. (Closed)
Patch Set: Handle Layout while animating Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/payments/view_stack.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/observer_list.h"
6 #include "base/run_loop.h"
7 #include "chrome/browser/ui/views/payments/view_stack.h"
8 #include "ui/gfx/animation/test_animation_delegate.h"
9 #include "ui/views/test/views_test_base.h"
10
11 class TestStackView : public views::View {
12 public:
13 class Observer {
14 public:
15 Observer() : view_deleted_(false) {}
16
17 void OnViewBeingDeleted() {
18 view_deleted_ = true;
19 }
20
21 bool view_deleted() { return view_deleted_; }
22
23 private:
24 bool view_deleted_;
25 };
26
27 TestStackView() {}
28 ~TestStackView() override {
29 for (auto& observer: observers_) {
30 observer.OnViewBeingDeleted();
31 }
32 }
33
34 void AddObserver(Observer* observer) {
35 observers_.AddObserver(observer);
36 }
37
38 private:
39 base::ObserverList<Observer> observers_;
40
41 DISALLOW_COPY_AND_ASSIGN(TestStackView);
42 };
43
44 class ViewStackTest : public views::ViewsTestBase {
45 public:
46 ViewStackTest()
47 : view_stack_(base::MakeUnique<ViewStack>()) {
48 view_stack_->SetBounds(0, 0, 10, 10);
49 view_stack_->Push(base::MakeUnique<TestStackView>(), false);
50 view_stack_->slide_in_animator_->SetAnimationDuration(1);
51 view_stack_->slide_out_animator_->SetAnimationDuration(1);
52 }
53
54 void AssertViewOnTopOfStack(views::View* view) {
55 gfx::Rect target = view_stack_->bounds();
56 target.set_origin(gfx::Point(0, 0));
57 EXPECT_EQ(target, view->bounds());
58 }
59
60 void AssertViewCompletelyNextToStack(views::View* view) {
61 gfx::Rect target = view_stack_->bounds();
62 target.set_origin(gfx::Point(view_stack_->width(), 0));
63 EXPECT_EQ(target, view->bounds());
64 }
65
66 std::unique_ptr<ViewStack> view_stack_;
67
68 DISALLOW_COPY_AND_ASSIGN(ViewStackTest);
69 };
70
71 TEST_F(ViewStackTest, TestInitialStateAddedAsChildView) {
72 EXPECT_EQ(1, view_stack_->child_count());
73 // This child was added without any animation so it's on top of its parent
74 // already.
75 AssertViewOnTopOfStack(view_stack_->top());
76 }
77
78 TEST_F(ViewStackTest, TestPushStateAddsViewToChildren) {
79 view_stack_->Push(base::MakeUnique<TestStackView>(), true);
80 EXPECT_EQ(2, view_stack_->child_count());
81
82 AssertViewCompletelyNextToStack(view_stack_->top());
83 }
84
85 TEST_F(ViewStackTest, TestPopStateRemovesChildViewAndCleansUpState) {
86 TestStackView::Observer observer;
87 std::unique_ptr<TestStackView> view = base::MakeUnique<TestStackView>();
88 view->AddObserver(&observer);
89 views::View* view_ptr = view.get();
90
91 view_stack_->Push(std::move(view), true);
92 EXPECT_TRUE(view_stack_->slide_in_animator_->IsAnimating());
93 view_stack_->slide_in_animator_->SetAnimationDelegate(
94 view_ptr,
95 std::unique_ptr<gfx::AnimationDelegate>(
96 new gfx::TestAnimationDelegate()));
97
98 AssertViewCompletelyNextToStack(view_ptr);
99
100 base::RunLoop().Run();
101 AssertViewOnTopOfStack(view_ptr);
102 EXPECT_FALSE(view_stack_->slide_in_animator_->IsAnimating());
103 view_stack_->Pop();
104
105 EXPECT_TRUE(view_stack_->slide_out_animator_->IsAnimating());
106 view_stack_->slide_out_animator_->SetAnimationDelegate(
107 view_ptr,
108 std::unique_ptr<gfx::AnimationDelegate>(
109 new gfx::TestAnimationDelegate()));
110
111 base::RunLoop().Run();
112 EXPECT_FALSE(view_stack_->slide_out_animator_->IsAnimating());
113
114 ASSERT_TRUE(observer.view_deleted());
115 }
116
117 TEST_F(ViewStackTest, TestDeletingViewCleansUpState) {
118 TestStackView::Observer observer;
119 std::unique_ptr<TestStackView> view = base::MakeUnique<TestStackView>();
120 view->AddObserver(&observer);
121 views::View* view_ptr = view.get();
122
123 view_stack_->Push(std::move(view), true);
124 EXPECT_TRUE(view_stack_->slide_in_animator_->IsAnimating());
125 view_stack_->slide_in_animator_->SetAnimationDelegate(
126 view_ptr,
127 std::unique_ptr<gfx::AnimationDelegate>(
128 new gfx::TestAnimationDelegate()));
129
130 AssertViewCompletelyNextToStack(view_ptr);
131
132 base::RunLoop().Run();
133 AssertViewOnTopOfStack(view_ptr);
134 EXPECT_FALSE(view_stack_->slide_in_animator_->IsAnimating());
135 view_stack_->Pop();
136
137 EXPECT_TRUE(view_stack_->slide_out_animator_->IsAnimating());
138 view_stack_.reset();
139
140 ASSERT_TRUE(observer.view_deleted());
141 }
142
143 TEST_F(ViewStackTest, TestLayoutUpdatesAnimations) {
144 TestStackView::Observer observer;
145 std::unique_ptr<TestStackView> view = base::MakeUnique<TestStackView>();
146 view->AddObserver(&observer);
147 views::View* view_ptr = view.get();
148
149 view_stack_->Push(std::move(view), true);
150 EXPECT_TRUE(view_stack_->slide_in_animator_->IsAnimating());
151 view_stack_->slide_in_animator_->SetAnimationDelegate(
152 view_ptr,
153 std::unique_ptr<gfx::AnimationDelegate>(
154 new gfx::TestAnimationDelegate()));
155
156 view_stack_->SetBounds(10, 10, 30, 30);
157 view_stack_->Layout();
158
159 base::RunLoop().Run();
160 AssertViewOnTopOfStack(view_ptr);
161 EXPECT_FALSE(view_stack_->slide_in_animator_->IsAnimating());
162 view_stack_->Pop();
163
164 EXPECT_TRUE(view_stack_->slide_out_animator_->IsAnimating());
165 view_stack_->slide_out_animator_->SetAnimationDelegate(
166 view_ptr,
167 std::unique_ptr<gfx::AnimationDelegate>(
168 new gfx::TestAnimationDelegate()));
169
170 base::RunLoop().Run();
171 EXPECT_FALSE(view_stack_->slide_out_animator_->IsAnimating());
172
173 ASSERT_TRUE(observer.view_deleted());
174 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/payments/view_stack.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698