ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm - Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm

Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/metrics/first_user_action_recorder.cc ('k') | ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm

diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm b/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm

index 6c0e9ce2b9bc59b20e444f5c303899b441a1bb74..e4e521b936e50d6b08fa19c8c4c9ebf20f57ef26 100644

--- a/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm

+++ b/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm

@@ -436,7 +436,8 @@ const CGFloat kNavigationBarTopMargin = 8.0;

new_tab_page_uma::RecordAction(self.browserState,

new_tab_page_uma::ACTION_OPENED_BOOKMARK);

- base::RecordAction(base::UserMetricsAction("MobileNTPBookmark"));

+ base::RecordAction(

+ base::UserMetricsAction("MobileBookmarkManagerEntryOpened"));

[_loader loadURL:url

referrer:web::Referrer()

transition:ui::PAGE_TRANSITION_AUTO_BOOKMARK