Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm

Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.h" 5 #import "ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/ios/block_types.h" 9 #include "base/ios/block_types.h"
10 #import "base/ios/weak_nsobject.h" 10 #import "base/ios/weak_nsobject.h"
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 } 429 }
430 430
431 #pragma mark - private methods 431 #pragma mark - private methods
432 432
433 - (void)loadURL:(const GURL&)url { 433 - (void)loadURL:(const GURL&)url {
434 if (url == GURL() || url.SchemeIs(url::kJavaScriptScheme)) 434 if (url == GURL() || url.SchemeIs(url::kJavaScriptScheme))
435 return; 435 return;
436 436
437 new_tab_page_uma::RecordAction(self.browserState, 437 new_tab_page_uma::RecordAction(self.browserState,
438 new_tab_page_uma::ACTION_OPENED_BOOKMARK); 438 new_tab_page_uma::ACTION_OPENED_BOOKMARK);
439 base::RecordAction(base::UserMetricsAction("MobileNTPBookmark")); 439 base::RecordAction(
440 base::UserMetricsAction("MobileBookmarkManagerEntryOpened"));
440 [_loader loadURL:url 441 [_loader loadURL:url
441 referrer:web::Referrer() 442 referrer:web::Referrer()
442 transition:ui::PAGE_TRANSITION_AUTO_BOOKMARK 443 transition:ui::PAGE_TRANSITION_AUTO_BOOKMARK
443 rendererInitiated:NO]; 444 rendererInitiated:NO];
444 } 445 }
445 446
446 #pragma mark - Views 447 #pragma mark - Views
447 448
448 - (void)loadWaitingView { 449 - (void)loadWaitingView {
449 DCHECK(!self.waitForModelView); 450 DCHECK(!self.waitForModelView);
(...skipping 886 matching lines...) Expand 10 before | Expand all | Expand 10 after
1336 } 1337 }
1337 1338
1338 - (NSIndexPath*)indexPathForCell:(UICollectionViewCell*)cell { 1339 - (NSIndexPath*)indexPathForCell:(UICollectionViewCell*)cell {
1339 DCHECK([self primaryView].collectionView); 1340 DCHECK([self primaryView].collectionView);
1340 NSIndexPath* indexPath = 1341 NSIndexPath* indexPath =
1341 [[self primaryView].collectionView indexPathForCell:cell]; 1342 [[self primaryView].collectionView indexPathForCell:cell];
1342 return indexPath; 1343 return indexPath;
1343 } 1344 }
1344 1345
1345 @end 1346 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698