ios/chrome/browser/metrics/first_user_action_recorder.cc - Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/metrics/first_user_action_recorder.cc

Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java ('k') | ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/metrics/first_user_action_recorder.cc

diff --git a/ios/chrome/browser/metrics/first_user_action_recorder.cc b/ios/chrome/browser/metrics/first_user_action_recorder.cc

index c079087632e61ba4611d44a0f2f4cd1648b25fb6..ab1d6bf42be614b11faf4d49eebf6c185230e63f 100644

--- a/ios/chrome/browser/metrics/first_user_action_recorder.cc

+++ b/ios/chrome/browser/metrics/first_user_action_recorder.cc

@@ -62,16 +62,26 @@ const char* kRethrownActions[] = {

// A list of actions that indicate a new task has been started.

const char* kNewTaskActions[] = {

- "MobileMenuAllBookmarks", "MobileMenuHistory",

- "MobileMenuNewIncognitoTab", "MobileMenuNewTab",

- "MobileMenuRecentTabs", "MobileMenuVoiceSearch",

- "MobileNTPBookmark", "MobileNTPForeignSession",

- "MobileNTPMostVisited", "MobileNTPShowBookmarks",

- "MobileNTPShowMostVisited", "MobileNTPShowOpenTabs",

- "MobileNTPSwitchToBookmarks", "MobileNTPSwitchToMostVisited",

- "MobileNTPSwitchToOpenTabs", "MobileTabStripNewTab",

- "MobileToolbarNewTab", "MobileToolbarStackViewNewTab",

- "MobileToolbarVoiceSearch", "OmniboxInputInProgress",

+ "MobileMenuAllBookmarks",

+ "MobileMenuHistory",

+ "MobileMenuNewIncognitoTab",

+ "MobileMenuNewTab",

+ "MobileMenuRecentTabs",

+ "MobileMenuVoiceSearch",

+ "MobileBookmarkManagerEntryOpened",

+ "MobileRecentTabManagerTabFromOtherDeviceOpened",

+ "MobileNTPMostVisited",

+ "MobileNTPShowBookmarks",

+ "MobileNTPShowMostVisited",

+ "MobileNTPShowOpenTabs",

+ "MobileNTPSwitchToBookmarks",

+ "MobileNTPSwitchToMostVisited",

+ "MobileNTPSwitchToOpenTabs",

+ "MobileTabStripNewTab",

+ "MobileToolbarNewTab",

+ "MobileToolbarStackViewNewTab",

+ "MobileToolbarVoiceSearch",

+ "OmniboxInputInProgress",

};

// Min and max values (in minutes) for the buckets in the duration histograms.