Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2528113003: Revert of Convert chart-json to Histograms. (Closed)

Created:
4 years ago by Primiano Tucci (use gerrit)
Modified:
4 years ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Convert chart-json to Histograms. (patchset #21 id:500001 of https://codereview.chromium.org/2474573002/ ) Reason for revert: As per go/catabug/3036 and comment #37 here this seems to not work well with run_benchmark and is breaking people's ability to run A/B tests. BUG=catapult:3036 Original issue's description: > Convert chart-json to Histograms. > > Currently, TBMv1 benchmarks and other scripts produce chart-json, > which cannot be displayed by results2.html. > > This CL implements ConvertChartJson(), which converts chart-json to > single-bin Histograms with IterationInfo diagnostics. > > HtmlOutputFormatter is now unused. If there are no complaints, then it and its > template can be deleted. > > https://screenshot.googleplex.com/omepkp6EUPN.png > > Legacy units and what to do about them: > https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZMykNHwU/edit > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4b8ce174b7ef489bd850983f3897b5d2bf8cbf33 TBR=eakuefner@chromium.org,sullivan@chromium.org,alexclarke@chromium.org,benjhayden@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -419 lines) Patch
M telemetry/telemetry/internal/results/html2_output_formatter.py View 1 chunk +5 lines, -30 lines 0 comments Download
M telemetry/telemetry/internal/results/html_output_formatter.py View 1 chunk +1 line, -2 lines 0 comments Download
M telemetry/telemetry/internal/results/results_options.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tracing/bin/results2json View 1 chunk +1 line, -2 lines 0 comments Download
M tracing/bin/valueset2html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/results2_template.html View 2 chunks +1 line, -3 lines 0 comments Download
M tracing/tracing/results_renderer.py View 2 chunks +11 lines, -10 lines 0 comments Download
M tracing/tracing/results_renderer_unittest.py View 3 chunks +5 lines, -9 lines 0 comments Download
M tracing/tracing/ui/base/box_chart.html View 1 chunk +0 lines, -30 lines 0 comments Download
D tracing/tracing/value/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tracing/tracing/value/chart_json_converter.html View 1 chunk +0 lines, -75 lines 0 comments Download
D tracing/tracing/value/chart_json_converter_test.html View 1 chunk +0 lines, -98 lines 0 comments Download
D tracing/tracing/value/convert_chart_json.py View 1 chunk +0 lines, -24 lines 0 comments Download
D tracing/tracing/value/convert_chart_json_cmdline.html View 1 chunk +0 lines, -20 lines 0 comments Download
M tracing/tracing/value/diagnostics/iteration_info.html View 3 chunks +0 lines, -12 lines 0 comments Download
M tracing/tracing/value/histogram_set.html View 1 chunk +6 lines, -16 lines 0 comments Download
D tracing/tracing/value/legacy_unit_info.html View 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Primiano Tucci (use gerrit)
Created Revert of Convert chart-json to Histograms.
4 years ago (2016-11-25 14:20:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528113003/1
4 years ago (2016-11-25 14:20:21 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/5727) Catapult Mac ...
4 years ago (2016-11-25 14:21:09 UTC) #5
eakuefner
Primiano, with https://codereview.chromium.org/2531423002 this should be fixed -- can this CL be closed?
4 years ago (2016-11-29 17:11:45 UTC) #6
Primiano Tucci (use gerrit)
4 years ago (2016-11-29 17:53:14 UTC) #7
On 2016/11/29 17:11:45, eakuefner wrote:
> Primiano, with https://codereview.chromium.org/2531423002 this should be fixed
> -- can this CL be closed?

ah didn't realize this didn't land. yup closing. thanks for the fix.

Powered by Google App Engine
This is Rietveld 408576698