Plumb label, benchmarkStartMs thru ChartJsonConverter.

Plumb label, benchmarkStartMs thru ChartJsonConverter.

A recent CL converted chart-json to Histograms so that TBMv1 and legacy telemetry
benchmarks could produce results2 so that we can delete results1.
https://codereview.chromium.org/2474573002

That CL forgot to plumb --results-label and benchmarkStartMs, so results were not
splayed into columns properly.

This CL plumbs label and benchmarkStartMs through ChartJsonConverter so that TBMv1
and legacy benchmark results are splayed into columns in results2.

https://x20web.corp.google.com/~benjhayden/2531423002.html

BUG=catapult:#3036

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a5f21f12661725115270981410de93ab09ce96ba

[benjhayden, 2016-11-28 18:37:25]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org, primiano@chromium.org

[benjhayden, 2016-11-28 18:37:26]

PTAL :-)

I'll finish the description momentarily.
I'm not sure if there's an easy way to test this or if it needs to be tested?

[benjhayden, 2016-11-28 18:43:39]

Description was changed from

==========
Plumb label, benchmarkStartMs thru ChartJsonConverter.

TODO finish description

BUG=catapult:#3036
==========

to

==========
Plumb label, benchmarkStartMs thru ChartJsonConverter.

A recent CL converted chart-json to Histograms so that TBMv1 and legacy
telemetry
benchmarks could produce results2 so that we can delete results1.
https://codereview.chromium.org/2474573002

That CL forgot to plumb --results-label and benchmarkStartMs, so results were
not
splayed into columns properly.

This CL plumbs label and benchmarkStartMs through ChartJsonConverter so that
TBMv1
and legacy benchmark results are splayed into columns in results2.

BUG=catapult:#3036
==========

[eakuefner, 2016-11-28 19:00:13]

lgtm

To your question, I've had an idea for a while that we should write an
end-to-end test of results2 using BrowserTestCase. I think that would be the
right place to address this functionality, but I don't think it needs to be done
in this CL.

https://codereview.chromium.org/2531423002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/results/html2_output_formatter.py (right):

https://codereview.chromium.org/2531423002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/results/html2_output_formatter.py:34:
chart_json['benchmarkStartMs'] = \
No backslash line continuations in Python source code. Please either use
parentheses, or extract iteration_info above (since you use it twice anyway).

[benjhayden, 2016-11-28 19:24:35]

Description was changed from

==========
Plumb label, benchmarkStartMs thru ChartJsonConverter.

A recent CL converted chart-json to Histograms so that TBMv1 and legacy
telemetry
benchmarks could produce results2 so that we can delete results1.
https://codereview.chromium.org/2474573002

That CL forgot to plumb --results-label and benchmarkStartMs, so results were
not
splayed into columns properly.

This CL plumbs label and benchmarkStartMs through ChartJsonConverter so that
TBMv1
and legacy benchmark results are splayed into columns in results2.

BUG=catapult:#3036
==========

to

==========
Plumb label, benchmarkStartMs thru ChartJsonConverter.

A recent CL converted chart-json to Histograms so that TBMv1 and legacy
telemetry
benchmarks could produce results2 so that we can delete results1.
https://codereview.chromium.org/2474573002

That CL forgot to plumb --results-label and benchmarkStartMs, so results were
not
splayed into columns properly.

This CL plumbs label and benchmarkStartMs through ChartJsonConverter so that
TBMv1
and legacy benchmark results are splayed into columns in results2.

https://x20web.corp.google.com/~benjhayden/2531423002.html

BUG=catapult:#3036
==========

[benjhayden, 2016-11-28 19:32:37]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-11-28 19:32:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2531423002/#ps20001
(title: "fix style")

[commit-bot: I haz the power, 2016-11-28 19:32:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 19:51:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480361557803800,
"parent_rev": "1e916c1c87c895ab139ee27078dbb324b53a451f", "commit_rev":
"a5f21f12661725115270981410de93ab09ce96ba"}

[commit-bot: I haz the power, 2016-11-28 19:51:24]

Description was changed from

==========
Plumb label, benchmarkStartMs thru ChartJsonConverter.

A recent CL converted chart-json to Histograms so that TBMv1 and legacy
telemetry
benchmarks could produce results2 so that we can delete results1.
https://codereview.chromium.org/2474573002

That CL forgot to plumb --results-label and benchmarkStartMs, so results were
not
splayed into columns properly.

This CL plumbs label and benchmarkStartMs through ChartJsonConverter so that
TBMv1
and legacy benchmark results are splayed into columns in results2.

https://x20web.corp.google.com/~benjhayden/2531423002.html

BUG=catapult:#3036
==========

to

==========
Plumb label, benchmarkStartMs thru ChartJsonConverter.

A recent CL converted chart-json to Histograms so that TBMv1 and legacy
telemetry
benchmarks could produce results2 so that we can delete results1.
https://codereview.chromium.org/2474573002

That CL forgot to plumb --results-label and benchmarkStartMs, so results were
not
splayed into columns properly.

This CL plumbs label and benchmarkStartMs through ChartJsonConverter so that
TBMv1
and legacy benchmark results are splayed into columns in results2.

https://x20web.corp.google.com/~benjhayden/2531423002.html

BUG=catapult:#3036

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-11-28 19:51:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...