Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tracing/tracing/ui/base/box_chart.html

Issue 2528113003: Revert of Convert chart-json to Histograms. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/results_renderer_unittest.py ('k') | tracing/tracing/value/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/base/box_chart.html
diff --git a/tracing/tracing/ui/base/box_chart.html b/tracing/tracing/ui/base/box_chart.html
index dd689f3ab68f35269964a18d965cbc59e683f08f..77f2334d0a5b3a1b65caed6dbcf9d44cb2ee92b1 100644
--- a/tracing/tracing/ui/base/box_chart.html
+++ b/tracing/tracing/ui/base/box_chart.html
@@ -43,36 +43,6 @@
get xAxisTickOffset() {
return 0.5;
- },
-
- updateDataRange_: function() {
- if (this.overrideDataRange_ !== undefined) {
- return;
- }
-
- this.autoDataRange_.reset();
- for (var datum of this.data_) {
- this.autoDataRange_.addValue(datum.percentile_0);
- this.autoDataRange_.addValue(datum.percentile_100);
- }
- },
-
- updateXAxis_: function(xAxis) {
- xAxis.selectAll('*').remove();
- if (this.hideXAxis) {
- return;
- }
-
- tr.ui.b.NameColumnChart.prototype.updateXAxis_.call(this, xAxis);
-
- var baseline = xAxis.selectAll('path').data([this]);
- baseline.enter().append('line')
- .attr('stroke', 'black')
- .attr('x1', this.xScale_(0))
- .attr('x2', this.xScale_(this.data_.length))
- .attr('y1', this.chartAreaSize.height)
- .attr('y2', this.chartAreaSize.height);
- baseline.exit().remove();
},
updateDataContents_: function(dataSel) {
« no previous file with comments | « tracing/tracing/results_renderer_unittest.py ('k') | tracing/tracing/value/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698