Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2527853002: Remove unused *Error fields in MetadataItem. (Closed)

Created:
4 years ago by oka
Modified:
4 years ago
Reviewers:
hirono, fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused *Error fields in MetadataItem. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bc1ec8569dc12a08ee96869e9e2bdc836acc4468 Cr-Commit-Position: refs/heads/master@{#434435}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Updated the comment for MetadataItem. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -108 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js View 1 3 1 chunk +0 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js View 1 2 3 7 chunks +1 line, -101 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
oka
PTAL.
4 years ago (2016-11-24 02:25:58 UTC) #3
fukino
https://codereview.chromium.org/2527853002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js File ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js (right): https://codereview.chromium.org/2527853002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js#newcode15 ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js:15: * Each property of MetadataItem has error property also. ...
4 years ago (2016-11-24 02:57:54 UTC) #4
fukino
Just to be safe, let me delegate this to hirono@, who added these properties in ...
4 years ago (2016-11-24 03:01:40 UTC) #6
oka
PTAL.
4 years ago (2016-11-24 15:21:18 UTC) #7
oka
https://codereview.chromium.org/2527853002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js File ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js (right): https://codereview.chromium.org/2527853002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js#newcode15 ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js:15: * Each property of MetadataItem has error property also. ...
4 years ago (2016-11-24 15:21:44 UTC) #8
hirono
lgtm
4 years ago (2016-11-24 23:57:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527853002/60001
4 years ago (2016-11-25 04:46:56 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-25 05:11:02 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-25 05:13:30 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bc1ec8569dc12a08ee96869e9e2bdc836acc4468
Cr-Commit-Position: refs/heads/master@{#434435}

Powered by Google App Engine
This is Rietveld 408576698