Files.app: Add error fields to MetadataItem.

Files.app: Add error fields to MetadataItem.

Previously if MetadataProvider fails to fetch metaata, there is no way to check
if the entry does not have a property or it fails to obtain the metadata.

The CL adds error fields to MetadataItem, which are cached with corresponding
property.

BUG=410766
TEST=FileManagerJsTest.MetadataCacheItem

Committed: https://crrev.com/3485fa9e6634462a76f8f887a5bb9ac3230730e7
Cr-Commit-Position: refs/heads/master@{#319043}

[hirono, 2015-03-04 09:05:03]

Patchset #1 (id:1) has been deleted

[hirono, 2015-03-04 09:05:08]

Patchset #1 (id:20001) has been deleted

[hirono, 2015-03-04 09:05:15]

Patchset #1 (id:40001) has been deleted

[hirono, 2015-03-04 09:05:54]

hirono@chromium.org changed reviewers:
+ yawano@chromium.org

[hirono, 2015-03-04 09:05:54]

PTAL, thanks!

[yawano, 2015-03-04 09:20:40]

lgtm with nit. While TEST field in the description is 'manually', this CL has
unit test.

https://codereview.chromium.org/977873002/diff/60001/ui/file_manager/file_man...
File
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js
(right):

https://codereview.chromium.org/977873002/diff/60001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js:107:
assertEquals(undefined, item.get(['propertyError']).property);
nit: Is this assertEquals necessary? As far as I tested on developer console, it
seems not to return any value.

[hirono, 2015-03-04 09:25:52]

> While TEST field in the description is 'manually', this CL has unit test.
Ah, yes. I updated the line. Thanks!

https://codereview.chromium.org/977873002/diff/60001/ui/file_manager/file_man...
File
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js
(right):

https://codereview.chromium.org/977873002/diff/60001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js:107:
assertEquals(undefined, item.get(['propertyError']).property);
On 2015/03/04 09:20:40, yawano wrote:
> nit: Is this assertEquals necessary? As far as I tested on developer console,
it
> seems not to return any value.

Done.

[hirono, 2015-03-04 09:25:55]

The CQ bit was checked by hirono@chromium.org

[hirono, 2015-03-04 09:25:56]

The patchset sent to the CQ was uploaded after l-g-t-m from yawano@chromium.org
Link to the patchset: https://codereview.chromium.org/977873002/#ps80001 (title:
"Remove unused assert")

[commit-bot: I haz the power, 2015-03-04 09:26:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/977873002/80001

[commit-bot: I haz the power, 2015-03-04 09:47:43]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2015-03-04 09:48:38]

Patchset 2 (id:??) landed as
https://crrev.com/3485fa9e6634462a76f8f887a5bb9ac3230730e7
Cr-Commit-Position: refs/heads/master@{#319043}