Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js

Issue 2527853002: Remove unused *Error fields in MetadataItem. (Closed)
Patch Set: Rebased. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js b/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js
index ed3ab22fa8fee778388ce9af7ef1245d206b56ac..0234b7683234e25baabdb2d4e222a520e108d8c6 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js
@@ -12,7 +12,7 @@
var ImageTransformation;
/**
- * Each property of MetadataItem has error property also.
+ * Metadata of a file.
* @constructor
* @struct
*/
@@ -24,21 +24,11 @@ function MetadataItem() {
this.size;
/**
- * @public {Error|undefined}
- */
- this.sizeError;
-
- /**
* @public {!Date|undefined}
*/
this.modificationTime;
/**
- * @public {Error|undefined}
- */
- this.modificationTimeError;
-
- /**
* Thumbnail URL obtained from external provider.
* @public {string|undefined}
*/
@@ -61,31 +51,16 @@ function MetadataItem() {
this.imageWidth;
/**
- * @public {Error|undefined}
- */
- this.imageWidthError;
-
- /**
* @public {number|undefined}
*/
this.imageHeight;
/**
- * @public {Error|undefined}
- */
- this.imageHeightError;
-
- /**
* @public {number|undefined}
*/
this.imageRotation;
/**
- * @public {Error|undefined}
- */
- this.imageRotationError;
-
- /**
* Thumbnail obtained from content provider.
* @public {string|undefined}
*/
@@ -125,11 +100,6 @@ function MetadataItem() {
this.pinned;
/**
- * @public {Error|undefined}
- */
- this.pinnedError;
-
- /**
* Whether the entry is cached locally.
* @public {boolean|undefined}
*/
@@ -147,43 +117,23 @@ function MetadataItem() {
this.hosted;
/**
- * @public {Error|undefined}
- */
- this.hostedError;
-
- /**
* Whether the entry is modified locally and not synched yet.
* @public {boolean|undefined}
*/
this.dirty;
/**
- * @public {Error|undefined}
- */
- this.dirtyError;
-
- /**
* Whether the entry is present or hosted;
* @public {boolean|undefined}
*/
this.availableOffline;
/**
- * @public {Error|undefined}
- */
- this.availableOfflineError;
-
- /**
* @public {boolean|undefined}
*/
this.availableWhenMetered;
/**
- * @public {Error|undefined}
- */
- this.availableWhenMeteredError;
-
- /**
* @public {string|undefined}
*/
this.customIconUrl;
@@ -199,74 +149,39 @@ function MetadataItem() {
this.contentMimeType;
/**
- * @public {Error|undefined}
- */
- this.contentMimeTypeError;
-
- /**
* Whether the entry is shared explicitly with me.
* @public {boolean|undefined}
*/
this.sharedWithMe;
/**
- * @public {Error|undefined}
- */
- this.sharedWithMeError;
-
- /**
* Whether the entry is shared publicly.
* @public {boolean|undefined}
*/
this.shared;
/**
- * @public {Error|undefined}
- */
- this.sharedError;
-
- /**
* URL for open a file in browser tab.
* @public {string|undefined}
*/
this.externalFileUrl;
/**
- * @public {Error|undefined}
- */
- this.externalFileUrlError;
-
- /**
* @public {string|undefined}
*/
this.mediaAlbum;
/**
- * @public {Error|undefined}
- */
- this.mediaAlbumError;
-
- /**
* @public {string|undefined}
*/
this.mediaTitle;
/**
- * @public {Error|undefined}
- */
- this.mediaTitleError;
-
- /**
* @public {string|undefined}
*/
this.mediaArtist;
/**
- * @public {Error|undefined}
- */
- this.mediaArtistError;
-
- /**
* Mime type obtained by content provider based on URL.
* TODO(hirono): Remove the mediaMimeType.
* @public {string|undefined}
@@ -274,28 +189,13 @@ function MetadataItem() {
this.mediaMimeType;
/**
- * @public {Error|undefined}
- */
- this.mediaMimeTypeError;
-
- /**
* "Image File Directory" obtained from EXIF header.
* @public {!Object|undefined}
*/
this.ifd;
/**
- * @public {Error|undefined}
- */
- this.ifdError;
-
- /**
* @public {boolean|undefined}
*/
this.exifLittleEndian;
-
- /**
- * @public {Error|undefined}
- */
- this.exifLittleEndianError;
}
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698