Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2538)

Unified Diff: Source/web/tests/TextFinderTest.cpp

Issue 252783002: Make Range.detach() a no-op (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/mac/WebSubstringUtil.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/TextFinderTest.cpp
diff --git a/Source/web/tests/TextFinderTest.cpp b/Source/web/tests/TextFinderTest.cpp
index 76aefdb87a3d63d1bcbdd6f4122688f672c4176f..4c4b77574d3bbab04a2c2cb5ea22673f0da286fd 100644
--- a/Source/web/tests/TextFinderTest.cpp
+++ b/Source/web/tests/TextFinderTest.cpp
@@ -78,10 +78,10 @@ TEST_F(TextFinderTest, FindTextSimple)
Range* activeMatch = textFinder().activeMatch();
EXPECT_TRUE(activeMatch);
if (activeMatch) {
- EXPECT_EQ(textNode, activeMatch->startContainer(ASSERT_NO_EXCEPTION));
- EXPECT_EQ(4, activeMatch->startOffset(ASSERT_NO_EXCEPTION));
- EXPECT_EQ(textNode, activeMatch->endContainer(ASSERT_NO_EXCEPTION));
- EXPECT_EQ(10, activeMatch->endOffset(ASSERT_NO_EXCEPTION));
+ EXPECT_EQ(textNode, activeMatch->startContainer());
+ EXPECT_EQ(4, activeMatch->startOffset());
+ EXPECT_EQ(textNode, activeMatch->endContainer());
+ EXPECT_EQ(10, activeMatch->endOffset());
}
findOptions.findNext = true;
@@ -89,10 +89,10 @@ TEST_F(TextFinderTest, FindTextSimple)
activeMatch = textFinder().activeMatch();
EXPECT_TRUE(activeMatch);
if (activeMatch) {
- EXPECT_EQ(textNode, activeMatch->startContainer(ASSERT_NO_EXCEPTION));
- EXPECT_EQ(14, activeMatch->startOffset(ASSERT_NO_EXCEPTION));
- EXPECT_EQ(textNode, activeMatch->endContainer(ASSERT_NO_EXCEPTION));
- EXPECT_EQ(20, activeMatch->endOffset(ASSERT_NO_EXCEPTION));
+ EXPECT_EQ(textNode, activeMatch->startContainer());
+ EXPECT_EQ(14, activeMatch->startOffset());
+ EXPECT_EQ(textNode, activeMatch->endContainer());
+ EXPECT_EQ(20, activeMatch->endOffset());
}
// Should wrap to the first match.
@@ -100,10 +100,10 @@ TEST_F(TextFinderTest, FindTextSimple)
activeMatch = textFinder().activeMatch();
EXPECT_TRUE(activeMatch);
if (activeMatch) {
- EXPECT_EQ(textNode, activeMatch->startContainer(ASSERT_NO_EXCEPTION));
- EXPECT_EQ(4, activeMatch->startOffset(ASSERT_NO_EXCEPTION));
- EXPECT_EQ(textNode, activeMatch->endContainer(ASSERT_NO_EXCEPTION));
- EXPECT_EQ(10, activeMatch->endOffset(ASSERT_NO_EXCEPTION));
+ EXPECT_EQ(textNode, activeMatch->startContainer());
+ EXPECT_EQ(4, activeMatch->startOffset());
+ EXPECT_EQ(textNode, activeMatch->endContainer());
+ EXPECT_EQ(10, activeMatch->endOffset());
}
}
« no previous file with comments | « Source/web/mac/WebSubstringUtil.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698