Make Range.detach() a no-op

Source/web/tests/TextFinderTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "web/TextFinder.h"
 
 #include "bindings/v8/ExceptionStatePlaceholder.h"
 #include "core/dom/Document.h"
@@ skipping 60 matching lines @@
     int identifier = 0;
     WebString searchText(String("FindMe"));
     WebFindOptions findOptions; // Default.
     bool wrapWithinFrame = true;
     WebRect* selectionRect = 0;
 
     ASSERT_TRUE(textFinder().find(identifier, searchText, findOptions, wrapWithinFrame, selectionRect));
     Range* activeMatch = textFinder().activeMatch();
     EXPECT_TRUE(activeMatch);
     if (activeMatch) {
-        EXPECT_EQ(textNode, activeMatch->startContainer(ASSERT_NO_EXCEPTION));
-        EXPECT_EQ(4, activeMatch->startOffset(ASSERT_NO_EXCEPTION));
-        EXPECT_EQ(textNode, activeMatch->endContainer(ASSERT_NO_EXCEPTION));
-        EXPECT_EQ(10, activeMatch->endOffset(ASSERT_NO_EXCEPTION));
+        EXPECT_EQ(textNode, activeMatch->startContainer());
+        EXPECT_EQ(4, activeMatch->startOffset());
+        EXPECT_EQ(textNode, activeMatch->endContainer());
+        EXPECT_EQ(10, activeMatch->endOffset());
     }
 
     findOptions.findNext = true;
     ASSERT_TRUE(textFinder().find(identifier, searchText, findOptions, wrapWithinFrame, selectionRect));
     activeMatch = textFinder().activeMatch();
     EXPECT_TRUE(activeMatch);
     if (activeMatch) {
-        EXPECT_EQ(textNode, activeMatch->startContainer(ASSERT_NO_EXCEPTION));
-        EXPECT_EQ(14, activeMatch->startOffset(ASSERT_NO_EXCEPTION));
-        EXPECT_EQ(textNode, activeMatch->endContainer(ASSERT_NO_EXCEPTION));
-        EXPECT_EQ(20, activeMatch->endOffset(ASSERT_NO_EXCEPTION));
+        EXPECT_EQ(textNode, activeMatch->startContainer());
+        EXPECT_EQ(14, activeMatch->startOffset());
+        EXPECT_EQ(textNode, activeMatch->endContainer());
+        EXPECT_EQ(20, activeMatch->endOffset());
     }
 
     // Should wrap to the first match.
     ASSERT_TRUE(textFinder().find(identifier, searchText, findOptions, wrapWithinFrame, selectionRect));
     activeMatch = textFinder().activeMatch();
     EXPECT_TRUE(activeMatch);
     if (activeMatch) {
-        EXPECT_EQ(textNode, activeMatch->startContainer(ASSERT_NO_EXCEPTION));
-        EXPECT_EQ(4, activeMatch->startOffset(ASSERT_NO_EXCEPTION));
-        EXPECT_EQ(textNode, activeMatch->endContainer(ASSERT_NO_EXCEPTION));
-        EXPECT_EQ(10, activeMatch->endOffset(ASSERT_NO_EXCEPTION));
+        EXPECT_EQ(textNode, activeMatch->startContainer());
+        EXPECT_EQ(4, activeMatch->startOffset());
+        EXPECT_EQ(textNode, activeMatch->endContainer());
+        EXPECT_EQ(10, activeMatch->endOffset());
     }
 }
 
 TEST_F(TextFinderTest, ScopeTextMatchesSimple)
 {
     document().body()->setInnerHTML("XXXXFindMeYYYYfindmeZZZZ", ASSERT_NO_EXCEPTION);
     Node* textNode = document().body()->firstChild();
 
     int identifier = 0;
     WebString searchText(String("FindMe"));
@@ skipping 35 matching lines @@
     EXPECT_EQ(3, textFinder().totalMatchCount());
     WebVector<WebFloatRect> matchRects;
     textFinder().findMatchRects(matchRects);
     ASSERT_EQ(3u, matchRects.size());
     EXPECT_EQ(findInPageRect(textInUElement, 0, textInUElement, 3), matchRects[0]);
     EXPECT_EQ(findInPageRect(textInBElement, 0, textInBElement, 3), matchRects[1]);
     EXPECT_EQ(findInPageRect(textInIElement, 0, textInIElement, 3), matchRects[2]);
 }
 
 } // namespace