Source/web/mac/WebSubstringUtil.mm - Issue 252783002: Make Range.detach() a no-op

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/mac/WebSubstringUtil.mm

Issue 252783002: Make Range.detach() a no-op (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/mac/WebSubstringUtil.mm

diff --git a/Source/web/mac/WebSubstringUtil.mm b/Source/web/mac/WebSubstringUtil.mm

index bdd2598b280c163f38299dd67e959cff9e0b3d9b..d14d4fd2ac8a79ed925f67b8e14baccbcd6c5342 100644

--- a/Source/web/mac/WebSubstringUtil.mm

+++ b/Source/web/mac/WebSubstringUtil.mm

@@ -70,7 +70,7 @@ static NSAttributedString* attributedSubstringFromRange(const Range* range)

if (!numCharacters)

continue;

- Node* container = it.range()->startContainer(IGNORE_EXCEPTION);

+ Node* container = it.range()->startContainer();

RenderObject* renderer = container->renderer();

ASSERT(renderer);

if (!renderer)

« no previous file with comments | « Source/web/WebRange.cpp ('k') | Source/web/tests/TextFinderTest.cpp » ('j') | no next file with comments »