FaceDetector: Pass |options| to parent constructor

This CL moves initialization of m_options from FaceDetector to its superclass ShapeDetector.

BUG=659139, 646083
Committed: https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216
Cr-Commit-Position: refs/heads/master@{#434196}

[xianglu, 2016-11-23 01:24:40]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 01:25:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-11-23 01:28:28]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 01:28:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-11-23 01:31:44]

Description was changed from

==========
Moved options to parent constructor

BUG=659139, 646083
==========

to

==========
This CL moves initialization of m_options from FaceDetector to its parent
ShapeDetector so we can add it to initialization list.

BUG=659139, 646083
==========

[xianglu, 2016-11-23 01:31:53]

Patchset #1 (id:1) has been deleted

[xianglu, 2016-11-23 01:32:23]

Description was changed from

==========
This CL moves initialization of m_options from FaceDetector to its parent
ShapeDetector so we can add it to initialization list.

BUG=659139, 646083
==========

to

==========
This CL moves initialization of m_options from FaceDetector to its parent
ShapeDetector so we can add it to initialization list.

BUG=659139, 646083
==========

[xianglu, 2016-11-23 01:32:44]

Description was changed from

==========
This CL moves initialization of m_options from FaceDetector to its parent
ShapeDetector so we can add it to initialization list.

BUG=659139, 646083
==========

to

==========
This CL moves initialization of m_options from FaceDetector to parent
ShapeDetector so we can add it to initialization list.

BUG=659139, 646083
==========

[xianglu, 2016-11-23 01:34:03]

Description was changed from

==========
This CL moves initialization of m_options from FaceDetector to parent
ShapeDetector so we can add it to initialization list.

BUG=659139, 646083
==========

to

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector so we can add it to initialization list.

BUG=659139, 646083
==========

[xianglu, 2016-11-23 01:35:31]

xianglu@chromium.org changed reviewers:
+ mcasas@chromium.org, reillyg@chromium.org

[xianglu, 2016-11-23 01:35:31]

ptal.

[haraken, 2016-11-23 01:37:33]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-11-23 01:37:34]

https://codereview.chromium.org/2527503003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h (right):

https://codereview.chromium.org/2527503003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h:29: explicit
ShapeDetector(LocalFrame&, const FaceDetectorOptions&);

Nit: Drop explicit.

[Reilly Grant (use Gerrit), 2016-11-23 01:42:04]

https://codereview.chromium.org/2527503003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2527503003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:57:
frame.interfaceProvider()->getInterface(mojo::GetProxy(&m_service));
You can use delegated constructors to avoid this code duplication. Just add
"ShapeDetector(frame)" to the list of initializers and it will call the other
constructor first.

[xianglu, 2016-11-23 01:55:53]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 01:56:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-11-23 01:57:38]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-11-23 01:59:41]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xianglu, 2016-11-23 02:08:52]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 02:09:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-11-23 02:10:17]

Description was changed from

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector so we can add it to initialization list.

BUG=659139, 646083
==========

to

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.

BUG=659139, 646083
==========

[xianglu, 2016-11-23 02:10:50]

Description was changed from

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.

BUG=659139, 646083
==========

to

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.
No new code is added.

BUG=659139, 646083
==========

[xianglu, 2016-11-23 02:11:01]

Description was changed from

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.
No new code is added.

BUG=659139, 646083
==========

to

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.

No new code is added.

BUG=659139, 646083
==========

[xianglu, 2016-11-23 02:11:15]

Description was changed from

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.

No new code is added.

BUG=659139, 646083
==========

to

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.

BUG=659139, 646083
==========

[xianglu, 2016-11-23 02:11:30]

ptal.

[Reilly Grant (use Gerrit), 2016-11-23 02:32:58]

lgtm

[haraken, 2016-11-23 02:33:50]

LGTM

[xianglu, 2016-11-23 02:54:08]

The CQ bit was unchecked by xianglu@chromium.org

[xianglu, 2016-11-23 02:54:08]

The CQ bit was checked by xianglu@chromium.org

[commit-bot: I haz the power, 2016-11-23 02:54:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 03:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 03:02:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xianglu, 2016-11-23 16:45:45]

xianglu@chromium.org changed reviewers:
+ tsepez@chromium.org

[xianglu, 2016-11-23 16:45:46]

ptal.

[xianglu, 2016-11-23 16:45:53]

ptal.

[Tom Sepez, 2016-11-23 17:09:20]

lgtm

[xianglu, 2016-11-23 17:16:32]

The CQ bit was checked by xianglu@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:16:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 17:24:14]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479921392995480,
"parent_rev": "64a5917bf288598bb57647753b70fdcd6d3627ac", "commit_rev":
"c6d479715fdfd066d365848f6cbcb27b6412e949"}

[commit-bot: I haz the power, 2016-11-23 17:24:53]

Description was changed from

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.

BUG=659139, 646083
==========

to

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.

BUG=659139, 646083
==========

[commit-bot: I haz the power, 2016-11-23 17:24:55]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-11-23 17:28:23]

Description was changed from

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.

BUG=659139, 646083
==========

to

==========
This CL moves initialization of m_options from FaceDetector to its superclass
ShapeDetector.

BUG=659139, 646083

Committed: https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216
Cr-Commit-Position: refs/heads/master@{#434196}
==========

[commit-bot: I haz the power, 2016-11-23 17:28:25]

Patchset 2 (id:??) landed as
https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216
Cr-Commit-Position: refs/heads/master@{#434196}