FaceDetector: Pass |options| to parent constructor

third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/shapedetection/ShapeDetector.h"
 
 #include "core/dom/DOMException.h"
 #include "core/dom/DOMRect.h"
 #include "core/dom/Document.h"
 #include "core/fetch/ImageResource.h"
@@ skipping 31 matching lines @@
 }
 
 }  // anonymous namespace
 
 ShapeDetector::ShapeDetector(LocalFrame& frame) {
   DCHECK(!m_service.is_bound());
   DCHECK(frame.interfaceProvider());
   frame.interfaceProvider()->getInterface(mojo::GetProxy(&m_service));
 }
 
+ShapeDetector::ShapeDetector(LocalFrame& frame,
+                             const FaceDetectorOptions& options)
+    : m_options(mojom::blink::FaceDetectorOptions::New()) {
+  DCHECK(!m_service.is_bound());
+  DCHECK(frame.interfaceProvider());
+  frame.interfaceProvider()->getInterface(mojo::GetProxy(&m_service));

[Reilly Grant (use Gerrit), 2016/11/23 01:42:04]

You can use delegated constructors to avoid this code duplication. Just add
"ShapeDetector(frame)" to the list of initializers and it will call the other
constructor first.

+  m_options->max_detected_faces = options.maxDetectedFaces();
+  m_options->fast_mode = options.fastMode();
+}
+
 ScriptPromise ShapeDetector::detectShapes(
     ScriptState* scriptState,
     DetectorType detectorType,
     const CanvasImageSourceUnion& imageSource) {
   CanvasImageSource* imageSourceInternal = toImageSourceInternal(imageSource);
 
   ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
   ScriptPromise promise = resolver->promise();
 
   if (!imageSourceInternal) {
@@ skipping 295 matching lines @@
   }
 
   resolver->resolve(detectedBarcodes);
 }
 
 DEFINE_TRACE(ShapeDetector) {
   visitor->trace(m_serviceRequests);
 }
 
 }  // namespace blink