Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

Issue 2527503003: FaceDetector: Pass |options| to parent constructor (Closed)
Patch Set: reillyg@ and haraken@ comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
diff --git a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
index b0c16fc86260b79972fa441ce3e8ff584e204c20..620cd8ed1f337c189f00c7b7a8dd6ecc01028568 100644
--- a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
+++ b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
@@ -18,11 +18,7 @@ FaceDetector* FaceDetector::create(ScriptState* scriptState,
FaceDetector::FaceDetector(LocalFrame& frame,
const FaceDetectorOptions& options)
- : ShapeDetector(frame) {
- m_options = mojom::blink::FaceDetectorOptions::New();
- m_options->max_detected_faces = options.maxDetectedFaces();
- m_options->fast_mode = options.fastMode();
-}
+ : ShapeDetector(frame, options) {}
ScriptPromise FaceDetector::detect(ScriptState* scriptState,
const CanvasImageSourceUnion& imageSource) {

Powered by Google App Engine
This is Rietveld 408576698