Issue 252703004: Rollback CL 240003005, causes deleting contexts after marker operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252703004: Rollback CL 240003005, causes deleting contexts after marker operations. (Closed)

Created:
6 years, 8 months ago by scheglov

Modified:
6 years, 8 months ago

Reviewers:
danrubel, keertip

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Rollback CL 240003005, causes deleting contexts after marker operations. R=danrubel@google.com, keertip@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=35462

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -10 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceDeltaProcessor.java	View		2 chunks	+17 lines, -6 lines	0 comments	Download
	M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceDeltaProcessorTest.java	View		2 chunks	+8 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

danrubel

LGTM. Apparently we need a different fix to solve dartbug.com/17179

6 years, 8 months ago (2014-04-25 22:39:31 UTC) #2

scheglov

6 years, 8 months ago (2014-04-26 01:28:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35462 (presubmit successful).