editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceDeltaProcessorTest.java - Issue 252703004: Rollback CL 240003005, causes deleting contexts after marker operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceDeltaProcessorTest.java

Issue 252703004: Rollback CL 240003005, causes deleting contexts after marker operations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceDeltaProcessor.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceDeltaProcessorTest.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceDeltaProcessorTest.java b/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceDeltaProcessorTest.java

index af64777eb970d49ffe8eb9f4d0d7e4801393035e..d3468daf3497fa8c1c4eb6c0a35a6dbe05f79579 100644

--- a/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceDeltaProcessorTest.java

+++ b/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceDeltaProcessorTest.java

@@ -14,9 +14,11 @@

package com.google.dart.tools.core.internal.analysis.model;

import com.google.dart.engine.context.AnalysisContext;

+import com.google.dart.engine.context.ChangeSet;

import com.google.dart.engine.index.Index;

import com.google.dart.engine.sdk.DartSdk;

import com.google.dart.engine.sdk.DirectoryBasedDartSdk;

+import com.google.dart.engine.source.FileBasedSource;

import com.google.dart.tools.core.DartCore;

import com.google.dart.tools.core.analysis.model.Project;

import com.google.dart.tools.core.analysis.model.ProjectManager;

@@ -142,13 +144,15 @@ public class WorkspaceDeltaProcessorTest extends TestCase {

MockFile file = pkg1.getMockFile("bar.dart");

MockDelta delta = new MockDelta(projectContainer);

delta.add(packages).add(pkg1).add(file);

- MockContext context = (MockContext) project.getDefaultContext();

processor.resourceChanged(new MockResourceChangeEvent(delta));

+ ChangeSet expected = new ChangeSet();

+ expected.changedSource(new FileBasedSource(file.getLocation().toFile()));

+ MockContext context = (MockContext) project.getDefaultContext();

+ context.assertChanged(expected);

+ context.assertNoCalls();

manager.assertProjectRemoved(null);

- MockContext newContext = (MockContext) project.getDefaultContext();

- assertNotSame(context, newContext);

+ processor.assertBackgroundAnalysisStarted(true);

}

public void test_resourceChanged_project_removed() {